Binary searched length cache and no superfluous cache clearing. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlm
force-pushed
the
feature/cache-peformance
branch
from
a6dadf2 to
4a7a0a0
Compare
|
@n8allan, can you please explain a little the idea or make a test to ensure that this method is really working? |
arlm
force-pushed
the
feature/cache-peformance
branch
from
4a7a0a0 to
718377e
Compare
LengthTo showed up as the main hot-spot on profiles of large method emissions. The replaced implementation would always start at the beginning in the event of a miss (even though length determination might have been done through a higher offset, and the cache was being cleared even in the most common event of a simply appended instruction. Closes PR #5 Co-authored-by: n8allan <[email protected]>
arlm
force-pushed
the
feature/cache-peformance
branch
from
718377e to
933638e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LengthTo showed up as the main hot-spot on profiles of large method emissions. The replaced implementation would always start at the beginning in the event of a miss (even though length determination might have been done through a higher offset, and the cache was being cleared even in the most common event of a simply appended instruction.
Closes PR #5
Co-authored-by: n8allan