Binary searched length cache and no superfluous cache clearing. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersed for validation purposes
…he final instructions in a method
…ome places that would violate correctness
…direct (inferencing needs a lot of work there).
…of(object).IsAssignableFrom(typeof(void)) == true
LengthTo showed up as the main hot-spot on profiles of large method emissions. The replaced implementation would always start at the beginning in the event of a miss (even though length determination might have been done through a higher offset, and the cache was being cleared even in the most common event of a simply appended instruction.
arlm
force-pushed
the
master
branch
2 times, most recently
from
e57a954 to
51b5efb
Compare
arlm
added a commit
that referenced
this pull request
Jul 12, 2019
LengthTo showed up as the main hot-spot on profiles of large method emissions. The replaced implementation would always start at the beginning in the event of a miss (even though length determination might have been done through a higher offset, and the cache was being cleared even in the most common event of a simply appended instruction. Closes PR #5 Co-authored-by: n8allan
|
This is handled by PR #9 |
arlm
added a commit
that referenced
this pull request
Jul 12, 2019
LengthTo showed up as the main hot-spot on profiles of large method emissions. The replaced implementation would always start at the beginning in the event of a miss (even though length determination might have been done through a higher offset, and the cache was being cleared even in the most common event of a simply appended instruction. Closes PR #5 Co-authored-by: n8allan <[email protected]>
arlm
added a commit
that referenced
this pull request
Jul 29, 2019
LengthTo showed up as the main hot-spot on profiles of large method emissions. The replaced implementation would always start at the beginning in the event of a miss (even though length determination might have been done through a higher offset, and the cache was being cleared even in the most common event of a simply appended instruction. Closes PR #5 Co-authored-by: n8allan <[email protected]>
arlm
added a commit
that referenced
this pull request
Aug 7, 2019
LengthTo showed up as the main hot-spot on profiles of large method emissions. The replaced implementation would always start at the beginning in the event of a miss (even though length determination might have been done through a higher offset, and the cache was being cleared even in the most common event of a simply appended instruction. Closes PR #5 Co-authored-by: n8allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LengthTo showed up as the main hot-spot on profiles of large method emissions. The replaced implementation would always start at the beginning in the event of a miss (even though length determination might have been done through a higher offset, and the cache was being cleared even in the most common event of a simply appended instruction.