fix(publish): quote release tag passed to SignPath#313
Conversation
SignPath's GitHub Action parses each parameter value as JSON, so a bare 20.2.0-rc.1 fails with a SyntaxError at position 4. Wrap the value in double quotes so it's interpreted as a JSON string.
Greptile SummaryThis PR fixes a one-line bug in the Windows-signing step of the publish workflow. Without quoting, SignPath's GitHub Action tried to parse version tags like
Confidence Score: 5/5Safe to merge; the change is a single-character addition that directly matches the documented root cause and is isolated to the SignPath parameters block. The fix is minimal and targeted: adding double quotes around the tag name turns an invalid JSON token into a valid JSON string for all tag formats, including stable semver and pre-release variants. No other steps, outputs, or secrets handling are affected. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(publish): quote release tag passed t..." | Re-trigger Greptile |
Problem
The Windows-signing job on the
20.2.0-rc.1release failed with:SignPath's GitHub Action parses each parameter VALUE as JSON.
20.2.0-rc.1is not a valid JSON literal (numbers can't have multiple decimal points; strings must be quoted), so the action errors out at position 4 ("20.2" followed by another.).Stable tags like
20.1.0happened to almost parse as JSON numbers, which is why the bug only surfaces now that we cut a pre-release with a dotted/dashed suffix.Fix
Wrap the release tag in double quotes inside the
parameters:block so SignPath seesversion: "20.2.0-rc.1"— a valid JSON string.Test plan
20.2.0-rc.1release and confirm the SignPath step succeeds and signed Windows binaries are produced.Upstream
The same fix needs to land in
appwrite/sdk-generator(templates/cli/.github/workflows/publish.yml) so the next CLI regeneration doesn't re-introduce the bug. A separate PR will follow.