fix(cli): quote release tag passed to SignPath#1525
Conversation
SignPath's GitHub Action parses each parameter value as JSON, so a bare 20.2.0-rc.1 fails with a SyntaxError at position 4. Wrap the value in double quotes so it's interpreted as a JSON string. Stable tags like 20.1.0 happened to almost parse as JSON numbers, masking the bug.
Greptile SummaryThis PR fixes a Windows code-signing failure caused by SignPath's GitHub Action parsing the
Confidence Score: 5/5Safe to merge — the change is a single-line quoting fix in a CI workflow template with no logic, no new dependencies, and a clear root-cause explanation. The single changed line correctly wraps the tag name in double quotes inside the YAML literal block, which is the standard way to ensure SignPath receives a valid JSON string regardless of tag format. The fix is minimal, targeted, and directly addresses the documented failure. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(cli): quote release tag passed to Si..." | Re-trigger Greptile |
Problem
The Windows-signing step on
sdk-for-cli's20.2.0-rc.1release failed with:SignPath's GitHub Action parses each parameter VALUE as JSON.
20.2.0-rc.1is not a valid JSON literal (numbers can't have multiple dots; strings must be quoted), so the action errors at position 4 (the second.after20.2).Stable tags like
20.1.0happened to almost parse as JSON numbers, which is why this bug only surfaced once we cut a pre-release tag with a dotted/dashed suffix.Fix
Wrap the release tag in double quotes inside
parameters:so SignPath seesversion: "20.2.0-rc.1"— a valid JSON string.Companion PR
A direct hotfix has been applied to
sdk-for-cliso the existing20.2.0-rc.1release can be re-run: appwrite/sdk-for-cli#313.Test plan
sdk-for-cliafter this merges and confirm the produced.github/workflows/publish.ymlhas the quoted version.20.2.0-rc.2) and verify SignPath accepts the parameter.