-
Notifications
You must be signed in to change notification settings - Fork 345
Feat/Python3 Update #2935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
4134N4
wants to merge
36
commits into
appleseedhq:master
Choose a base branch
from
4134N4:feat/python3-update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/Python3 Update #2935
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
3e306b0
Quick PLY mesh file reader test fix.
a3f553b
CMake changes
5ee8167
Updated types
dba0eb6
Python slot fix
2c47f57
Added correct prefix to _appleseedstudio PyImport.
22f6d1a
Linking appleseed.python3 to appleseed.studio.
d2c37c1
wchar_t conversion changes
5059842
Ensured build-ability with Python 2.7
b854b28
Quick PLY mesh file reader test fix.
13d053e
update utils.py script to python 3
geckguy 1b27ca2
change subprocess function
geckguy 91fbdef
update runtestsuite to py3
geckguy ce4e7a3
replace several next() and map functions
geckguy 761319d
fix tag err
geckguy 040378d
update cleanmany and convert many files
geckguy 84b4716
rename winreg module and few other python3 updates
geckguy bf6d5ed
update to python3
geckguy 56aaf80
update to python3
geckguy 4e13796
finish updating scripts folder to py3
geckguy 579f396
update to py3
geckguy d709c99
update to py3
geckguy 1e4247a
Update to py3
geckguy 4980982
Update to py3
geckguy ad03c52
Update to py3
geckguy 7ce8a9b
Update __init__.py
geckguy 76bedd9
Update convertmany.py
geckguy d2af333
Update oslextractmeta.py
geckguy 1ad18be
Update rendermanager.py
geckguy 88eba53
Update rendernode.py
geckguy 8114301
Update aspaths2json.py
geckguy 5393c27
Update sortincludes.py
geckguy 1d149d6
Added .vs to .gitignore.
4ec345c
Update runtestsuit.py and png.py.
9f7c644
Small setup script fix (Ubuntu 24).
4134N4 f1118e2
Merge pull request #3 from 4134N4/feat/python3-update-geckguy
4134N4 feed047
Removed debugging pragma messages.
4134N4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ dependencies/ | |
| sandbox/shaders/ | ||
| *.pyc | ||
| __pycache__ | ||
| .vs/ | ||
| .vscode/ | ||
| dependencies/ | ||
| collected-deps/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does appleseed even support the Python2 bindings now? If not, the option should be completely removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appleseed should still build and work with Python 2 Bindings as before.
With the preprocessor I check
And in cmake I check for either
WITH_PYTHON2_BINDINGSandWITH_PYTHON3_BINDINGSrespectively.I've tested this on Ubuntu 22 (where Python 2 is still supported).
So the bindings can still support Python 2. The Python scripts however only support Python 3.