Feat/Python3 Update #2935
Open
Feat/Python3 Update #2935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The include order needed to be adjusted some cases, s.t. specific Python headers were included before QT headers, as both have `slots` defined that conflict with each other.
In the same way the linking of appleseed.python2 and appleseed.studio is done.
via preprocessor instructions TODO: remove debugging pragmas for pull request.
Wrong assertion.
And removed added files.
Added OpenEXR_ROOT to OCIO cmake command. Else it causes problems on on Ubuntu 24.04.
Python3 update /w geckguy branch into "default" Feat/python3 update branch.
gospodnetic
reviewed
Nov 25, 2025
| WITH_TOOLS=ON | ||
| WITH_PYTHON2_BINDINGS=ON | ||
| WITH_PYTHON3_BINDINGS=OFF | ||
| WITH_PYTHON2_BINDINGS=OFF |
Member
There was a problem hiding this comment.
Does appleseed even support the Python2 bindings now? If not, the option should be completely removed
Contributor
Author
There was a problem hiding this comment.
Appleseed should still build and work with Python 2 Bindings as before.
With the preprocessor I check
#if PY_MAJOR_VERSION == 2
// Python 2 Compatible Code
#endif#if PY_MAJOR_VERSION == 3
// Python 3 Compatible Code
#endifAnd in cmake I check for either WITH_PYTHON2_BINDINGS and WITH_PYTHON3_BINDINGS respectively.
I've tested this on Ubuntu 22 (where Python 2 is still supported).
So the bindings can still support Python 2. The Python scripts however only support Python 3.
|
Thanks for taking this forward! @4134N4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Appleseed to build with Python 3. Namely, Appleseed now builds with Python 3 with
(and
WITH_PYTHON2_BINDINGS=OFF).This PR also includes the commits of @geckguy in PR "Updated all the python files to Python3" #2924
It was tested (CLI unit tests and
runtestsuite.py) on Ubuntu 22.04 (for Python 3.10 and Python 2.7 -- checking if Python 2 bindings still worked) and on Ubuntu 24.04 (for Python 3.12).