-
Notifications
You must be signed in to change notification settings - Fork 16.1k
feat(Chart): Save Chart State globally #35343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
geido
merged 28 commits into
apache:master
from
alexandrusoare:alexandrusoare/feat/chart-state-save
Oct 29, 2025
+1,772
−38
Merged
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
05217ab
saving chart state
alexandrusoare c0f6bd6
Merge branch 'master' of https://github.com/apache/superset into alex…
alexandrusoare 182ab20
Merge branch 'master' of https://github.com/apache/superset into alex…
alexandrusoare 33bd850
fixing(types): fixing CIs
alexandrusoare bc7e7f6
Merge branch 'master' of https://github.com/apache/superset into alex…
alexandrusoare c068cd5
feat(fixes): state update fixes
alexandrusoare 90fb3d6
fix(functionality): fixes
alexandrusoare 36d5c4e
refactor(code): refactoring the code a bit
alexandrusoare 3efcc5c
refactor(code): refactoring the code a bit
alexandrusoare bf5c9bc
fix(types): changing any types
alexandrusoare 7e3b5bd
Merge branch 'master' of https://github.com/apache/superset into alex…
alexandrusoare 8c6885a
refactor(PR): refactoring by PR reviews
alexandrusoare bee0129
fix(order): fixed orderBy bug
alexandrusoare b125d80
adding test file
alexandrusoare 7d7dd87
Merge branch 'master' into alexandrusoare/feat/chart-state-save
alexandrusoare 63db6a6
refactor(logic): refactoring hardcoded logic
alexandrusoare f0a87d8
merging
alexandrusoare d948da9
Merge branch 'alexandrusoare/feat/chart-state-save' of https://github…
alexandrusoare 5cf0a5f
refactor(backend): refactor hardcoded logic
alexandrusoare 4fd19ea
refactor(chart): big refactor
alexandrusoare 588688c
fix(CI): fixing CI issue
alexandrusoare 7237eae
fix(CI): fix another CI issue
alexandrusoare 0dd8561
fix(CI): fixing CIs
alexandrusoare 2cae894
Merge branch 'master' of https://github.com/apache/superset into alex…
alexandrusoare 7e9fb00
fix(chart): fix sorting when server pagination is on
alexandrusoare bc1a717
refactor(embedding): refactoring embedding
alexandrusoare c59b946
refactor(package): removing package-lock.json
alexandrusoare 705dd8c
small refactor
alexandrusoare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
superset-frontend/packages/superset-ui-core/src/types/AgGrid.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import type { ColumnState, SortModelItem } from 'ag-grid-community'; | ||
|
|
||
| // AG Grid filter type enums | ||
| export enum AgGridFilterType { | ||
| Text = 'text', | ||
| Number = 'number', | ||
| Date = 'date', | ||
| Set = 'set', | ||
| } | ||
|
|
||
| export enum AgGridTextFilterOperator { | ||
| Equals = 'equals', | ||
| NotEqual = 'notEqual', | ||
| Contains = 'contains', | ||
| NotContains = 'notContains', | ||
| StartsWith = 'startsWith', | ||
| EndsWith = 'endsWith', | ||
| Blank = 'blank', | ||
| NotBlank = 'notBlank', | ||
| } | ||
|
|
||
| export enum AgGridNumberFilterOperator { | ||
| Equals = 'equals', | ||
| NotEqual = 'notEqual', | ||
| LessThan = 'lessThan', | ||
| LessThanOrEqual = 'lessThanOrEqual', | ||
| GreaterThan = 'greaterThan', | ||
| GreaterThanOrEqual = 'greaterThanOrEqual', | ||
| InRange = 'inRange', | ||
| Blank = 'blank', | ||
| NotBlank = 'notBlank', | ||
| } | ||
|
|
||
| export interface AgGridSortModel extends SortModelItem { | ||
| sortIndex?: number; | ||
| } | ||
|
|
||
| export interface AgGridFilter { | ||
| filterType?: string; | ||
| type?: string; | ||
| filter?: string | number; | ||
| filterTo?: number; | ||
| values?: string[]; | ||
| dateFrom?: string; | ||
| dateTo?: string; | ||
| operator?: 'AND' | 'OR'; | ||
| condition1?: AgGridFilter; | ||
| condition2?: AgGridFilter; | ||
| conditions?: AgGridFilter[]; | ||
| } | ||
|
|
||
| export interface AgGridFilterModel { | ||
| [colId: string]: AgGridFilter; | ||
| } | ||
|
|
||
| export interface AgGridChartState { | ||
| columnState: ColumnState[]; | ||
| sortModel: AgGridSortModel[]; | ||
| filterModel: AgGridFilterModel; | ||
| columnOrder?: string[]; | ||
| pageSize?: number; | ||
| currentPage?: number; | ||
| } | ||
alexandrusoare marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.