feat(Chart): Save Chart State globally

[alexandrusoare]

SUMMARY

The changes you do in a dashboard for a chart (reorder columns, hide columns, filters etc) should be saved.

FEATURE_AG_GRID_TABLE_ENABLED=true

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

1. Go to a dashboard
2. Add a Table V2
3. Make some modifications to it (eg. reorder columns, apply a filter)
4. Export the chart as a csv or share the dashboard as a permalink
5. The changes should be reflected in the permalink/csv

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.04%. Comparing base (6704c0a) to head (705dd8c).
⚠️ Report is 11 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/models/helpers.py	77.77%	4 Missing ⚠️
superset/views/core.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #35343       +/-   ##
===========================================
+ Coverage        0   71.04%   +71.04%     
===========================================
  Files           0      605      +605     
  Lines           0    44224    +44224     
  Branches        0     4785     +4785     
===========================================
+ Hits            0    31420    +31420     
- Misses          0    11559    +11559     
- Partials        0     1245     +1245     

Flag	Coverage Δ
hive	45.69% <13.33%> (?)
mysql	70.09% <83.33%> (?)
postgres	70.14% <83.33%> (?)
presto	49.35% <46.66%> (?)
python	71.01% <83.33%> (?)
sqlite	69.74% <83.33%> (?)
unit	100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	High Redux State Coupling ▹ view	✅ Fix detected
	Missing default value for is_ag_grid_chart boolean field ▹ view	✅ Fix detected
	Chart state tightly coupled to AgGrid ▹ view	✅ Fix detected
	Violation of Single Responsibility Principle ▹ view	✅ Fix detected
	Unused gridRef prop creates broken external API access ▹ view
	Missing parameter validation in updateChartState ▹ view
	Unwired chart state callback ▹ view	✅ Fix detected

Files scanned

​

File Path	Reviewed
superset/dashboards/permalink/types.py	✅
superset/dashboards/permalink/schemas.py	✅
superset-frontend/src/dashboard/types/chartState.ts	✅
superset-frontend/src/embedded/api.tsx	✅
superset-frontend/src/dashboard/components/menu/ShareMenuItems/index.tsx	✅
superset-frontend/src/dashboard/components/URLShortLinkButton/index.tsx	✅
superset-frontend/plugins/plugin-chart-ag-grid-table/src/types.ts	✅
superset-frontend/src/utils/urlUtils.ts	✅
superset-frontend/src/dashboard/types.ts	✅
superset-frontend/src/visualizations/presets/MainPreset.js	✅
superset-frontend/src/dashboard/reducers/dashboardState.js	✅
superset-frontend/src/embedded/index.tsx	✅
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTableChart.tsx	✅
superset-frontend/src/dashboard/containers/DashboardPage.tsx	✅
superset-frontend/src/components/Chart/Chart.tsx	✅
superset-frontend/src/dashboard/actions/hydrate.js	✅
superset-frontend/src/components/Chart/ChartRenderer.jsx	✅
superset-frontend/plugins/plugin-chart-ag-grid-table/src/buildQuery.ts	✅
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx	✅
superset-frontend/plugins/plugin-chart-ag-grid-table/src/transformProps.ts	✅
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.jsx	✅
superset-frontend/src/dashboard/actions/dashboardState.js	✅
superset/charts/schemas.py	✅
superset/connectors/sqla/models.py	✅
superset/models/helpers.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[github-actions]

🎪 Showtime is building environment on GHA for bc1a717

[github-actions]

🎪 Showtime deployed environment on GHA for bc1a717

• Environment: http://35.166.24.243:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

[github-actions]

⚠️ DEPRECATED WORKFLOW ⚠️

@kgabryje This workflow is deprecated! Please use the new Superset Showtime system instead:

• Replace "testenv-up" label with "🎪 trigger-start"
• Better reliability and easier management
• See https://github.com/mistercrunch/superset-showtime for details

Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

[github-actions]

@kgabryje Ephemeral environment spinning up at http://50.112.177.10:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

[alexandrusoare]

Also, it would be great to add a video!

I am not able to add a video as there a current limit of 10MB of video uploads, I uploaded some screenshots

[kgabryje]

LGTM

[msyavuz]

LGTM as well

[amaannawab923]

LGTM !!