Skip to content

Service and TCPService source support analyze TLS mode. #13559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2025
Merged

Service and TCPService source support analyze TLS mode. #13559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
144f4aa
Service and TCPService source support analyze TLS mode.
wankai123 Oct 31, 2025
6595c5b
period
wankai123 Oct 31, 2025
f6d9942
Merge branch 'master' of https://github.com/apache/skywalking into se…
wankai123 Oct 31, 2025
60ec0a1
add more verify count for kong e2e
wankai123 Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/en/changes/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@
* Make MAL percentile align with OAL percentile calculation.
* Update Grafana dashboards for OAP observability.
* BanyanDB: fix query `getInstance` by instance ID.
* Support the go agent(0.7.0 release) bundled pprof profiling feature.
* Support the go agent(0.7.0 release) bundled pprof profiling feature.
* Service and TCPService source support analyze TLS mode.
* Library-pprof-parser: feat: add PprofSegmentParser.
* Storage: feat: add languageType column to ProfileThreadSnapshotRecord.
* Feat: add go profile analyzer
Expand Down
30 changes: 16 additions & 14 deletions docs/en/concepts-and-designs/scope-definitions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,21 @@ Using the Aggregation Function, the requests will be grouped by time and **Group

This calculates the metrics data from each request of the service.

| Name | Remarks | Group Key | Type |
|---------------------------|---------------------------------------------------------------------------------------------------------------------------------|-----------|------------------------|
| name | The name of the service. | | string |
| layer | Layer represents an abstract framework in the computer science, such as operation system(OS_LINUX layer), Kubernetes(k8s layer) | | enum |
| serviceInstanceName | The name of the service instance ID. | | string |
| endpointName | The name of the endpoint, such as a full path of HTTP URI. | | string |
| latency | The time taken by each request. | | int |
| status | Indicates the success or failure of the request. | | bool(true for success) |
| httpResponseStatusCode | The response code of the HTTP response, and if this request is the HTTP call. E.g. 200, 404, 302 | | int |
| rpcStatusCode | The string value of the rpc response code. | | string |
| type | The type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum |
| tags | The labels of each request. Each value is made up by `TagKey:TagValue` in the segment. | | `List<String>` |
| tag | The key-value pair of span tags in the segment. | | `Map<String, String>` |
| sideCar.internalErrorCode | The sidecar/gateway proxy internal error code. The value is based on the implementation. | | string |
| Name | Remarks | Group Key | Type |
|----------------------------|---------------------------------------------------------------------------------------------------------------------------------|-----------|------------------------|
| name | The name of the service. | | string |
| layer | Layer represents an abstract framework in the computer science, such as operation system(OS_LINUX layer), Kubernetes(k8s layer) | | enum |
| serviceInstanceName | The name of the service instance ID. | | string |
| endpointName | The name of the endpoint, such as a full path of HTTP URI. | | string |
| latency | The time taken by each request. | | int |
| status | Indicates the success or failure of the request. | | bool(true for success) |
| httpResponseStatusCode | The response code of the HTTP response, and if this request is the HTTP call. E.g. 200, 404, 302 | | int |
| rpcStatusCode | The string value of the rpc response code. | | string |
| type | The type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum |
| tags | The labels of each request. Each value is made up by `TagKey:TagValue` in the segment. | | `List<String>` |
| tag | The key-value pair of span tags in the segment. | | `Map<String, String>` |
| sideCar.internalErrorCode | The sidecar/gateway proxy internal error code. The value is based on the implementation. | | string |
| tlsMode | The TLS mode of the service. | | string |

### SCOPE `TCPService`

Expand All @@ -35,6 +36,7 @@ This calculates the metrics data from each request of the TCP service.
| sideCar.internalErrorCode | The sidecar/gateway proxy internal error code. The value is based on the implementation. | | string |
| receivedBytes | The received bytes of the TCP traffic. | | long |
| sentBytes | The sent bytes of the TCP traffic. | | long |
| tlsMode | The TLS mode of the service. | | string |

### SCOPE `ServiceInstance`

Expand Down
3 changes: 3 additions & 0 deletions ...erver/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/Service.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ public String getEntityId() {
private SideCar sideCar = new SideCar();
@Getter
@Setter
private String tlsMode;
@Getter
@Setter
@ScopeDefaultColumn.DefinedByField(columnName = "attr0", isAttribute = true)
private String attr0;
@Getter
Expand Down
5 changes: 3 additions & 2 deletions ...er/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/TCPService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,15 @@ public String getEntityId() {
@Getter
@Setter
private SideCar sideCar = new SideCar();

@Getter
@Setter
private long receivedBytes;

@Getter
@Setter
private long sentBytes;
@Getter
@Setter
private String tlsMode;

public String getTag(String key) {
return originalTags.get(key);
Expand Down
2 changes: 2 additions & 0 deletions ...src/main/java/org/apache/skywalking/aop/server/receiver/mesh/TelemetryDataDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ private static void toService(HTTPServiceMeshMetric.Builder metrics, long minute
service.getSideCar().setInternalErrorCode(metrics.getInternalErrorCode());
service.getSideCar().setInternalRequestLatencyNanos(metrics.getInternalRequestLatencyNanos());
service.getSideCar().setInternalResponseLatencyNanos(metrics.getInternalResponseLatencyNanos());
service.setTlsMode(metrics.getTlsMode());

SOURCE_RECEIVER.receive(service);
}
Expand All @@ -241,6 +242,7 @@ private static void toTCPService(TCPServiceMeshMetric.Builder metrics, long minu
service.getSideCar().setInternalResponseLatencyNanos(metrics.getInternalResponseLatencyNanos());
service.setReceivedBytes(metrics.getReceivedBytes());
service.setSentBytes(metrics.getSentBytes());
service.setTlsMode(metrics.getTlsMode());

SOURCE_RECEIVER.receive(service);
}
Expand Down
2 changes: 1 addition & 1 deletion test/e2e-v2/cases/kong/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ setup:

verify:
retry:
count: 20
count: 60
interval: 3s
cases:
- includes:
Expand Down
Loading