Skip to content

Conversation

@wankai123
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wankai123 wankai123 added this to the 10.3.0 milestone Oct 31, 2025
@wankai123 wankai123 added backend OAP backend related. enhancement Enhancement on performance or codes labels Oct 31, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds TLS mode support to Service and TCPService sources in Apache SkyWking's mesh receiver plugin. The changes enable tracking and analysis of TLS encryption modes for HTTP and TCP service mesh metrics.

Key Changes:

  • Added tlsMode field to Service and TCPService source classes
  • Updated telemetry data dispatcher to populate tlsMode from incoming metrics
  • Added documentation for the new field in scope definitions

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Service.java Added tlsMode field with getter/setter to track TLS mode for HTTP services
TCPService.java Added tlsMode field with getter/setter to track TLS mode for TCP services
TelemetryDataDispatcher.java Updated dispatcher methods to set TLS mode from incoming metrics for both HTTP and TCP services
scope-definitions.md Added tlsMode field documentation to Service and TCPService scope tables
changes.md Added changelog entry noting TLS mode analysis support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

wu-sheng
wu-sheng previously approved these changes Oct 31, 2025
wu-sheng
wu-sheng previously approved these changes Oct 31, 2025
@wu-sheng wu-sheng merged commit f0d3d9b into apache:master Nov 1, 2025
351 of 353 checks passed
@wankai123 wankai123 deleted the service-mtls branch November 1, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. enhancement Enhancement on performance or codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants