Skip to content

[Fix][Connector-V2] Ignore JdbcConnectorException on JDBC statement close #9942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
+3 −3
Open

[Fix][Connector-V2] Ignore JdbcConnectorException on JDBC statement close #9942

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2d0e78c
[Fix][Connector-V2] Ignore exceptions on JDBC statement close
dybyte Oct 13, 2025
cc70aa3
[Fix][Connector-V2] Ignore exception on JDBC statement close
dybyte Oct 13, 2025
2d3b3ea
[Fix][Connector-V2] code style
dybyte Oct 13, 2025
b7dacb5
[Fix][Connector-V2] Ignore JdbcConnectorException on JDBC statement c…
dybyte Oct 20, 2025
bbecded
[Fix][Connector-V2] Ignore JdbcConnectorException on JDBC statement c…
dybyte Oct 20, 2025
298da57
[Fix][Connector-V2] Ignore JdbcConnectorException on JDBC statement c…
dybyte Oct 20, 2025
005a600
[Fix][Connector-V2] Ignore JdbcConnectorException on JDBC statement c…
dybyte Nov 3, 2025
e74b5f7
Merge branch 'dev' of https://github.com/apache/seatunnel into fix/jd…
dybyte Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcSinkOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public class JdbcSinkOptions extends JdbcCommonOptions {
.withDescription("auto commit");

public static final Option<Integer> MAX_RETRIES =
Options.key("max_retries").intType().defaultValue(0).withDescription("max_retired");
Options.key("max_retries").intType().defaultValue(0).withDescription("max_retries");

public static final Option<String> XA_DATA_SOURCE_CLASS_NAME =
Options.key("xa_data_source_class_name")
Expand Down
4 changes: 4 additions & 0 deletions ...nnel/connectors/seatunnel/jdbc/internal/executor/BufferReducedBatchStatementExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

import lombok.NonNull;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

import java.sql.Connection;
import java.sql.SQLException;
Expand All @@ -35,6 +36,7 @@
import java.util.function.Function;

@RequiredArgsConstructor
@Slf4j
public class BufferReducedBatchStatementExecutor
implements JdbcBatchStatementExecutor<SeaTunnelRow> {
@NonNull private final JdbcBatchStatementExecutor<SeaTunnelRow> upsertExecutor;
Expand Down Expand Up @@ -100,6 +102,8 @@ public void closeStatements() throws SQLException {
if (!buffer.isEmpty()) {
executeBatch();
}
} catch (JdbcConnectorException e) {
log.error("Failed to execute remaining batch", e);
} finally {
upsertExecutor.closeStatements();
deleteExecutor.closeStatements();
Expand Down
5 changes: 5 additions & 0 deletions ...seatunnel/connectors/seatunnel/jdbc/internal/executor/BufferedBatchStatementExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@
package org.apache.seatunnel.connectors.seatunnel.jdbc.internal.executor;

import org.apache.seatunnel.api.table.type.SeaTunnelRow;
import org.apache.seatunnel.connectors.seatunnel.jdbc.exception.JdbcConnectorException;

import lombok.NonNull;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

import java.sql.Connection;
import java.sql.SQLException;
Expand All @@ -29,6 +31,7 @@
import java.util.function.Function;

@RequiredArgsConstructor
@Slf4j
public class BufferedBatchStatementExecutor implements JdbcBatchStatementExecutor<SeaTunnelRow> {
@NonNull private final JdbcBatchStatementExecutor<SeaTunnelRow> statementExecutor;
@NonNull private final Function<SeaTunnelRow, SeaTunnelRow> valueTransform;
Expand Down Expand Up @@ -61,6 +64,8 @@ public void closeStatements() throws SQLException {
if (!buffer.isEmpty()) {
executeBatch();
}
} catch (JdbcConnectorException e) {
log.error("Failed to execute remaining batch", e);
} finally {
statementExecutor.closeStatements();
}
Expand Down
4 changes: 4 additions & 0 deletions ...nel/connectors/seatunnel/jdbc/internal/executor/InsertOrUpdateBatchStatementExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

import lombok.NonNull;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;

import javax.annotation.Nullable;

Expand All @@ -36,6 +37,7 @@
import java.util.function.Function;

@RequiredArgsConstructor
@Slf4j
public class InsertOrUpdateBatchStatementExecutor
implements JdbcBatchStatementExecutor<SeaTunnelRow> {
private final StatementFactory existStmtFactory;
Expand Down Expand Up @@ -121,6 +123,8 @@ public void closeStatements() throws SQLException {
if (!submitted) {
executeBatch();
}
} catch (JdbcConnectorException e) {
log.error("Failed to execute remaining batch", e);
} finally {
for (PreparedStatement statement :
Arrays.asList(existStatement, insertStatement, updateStatement)) {
Expand Down