-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[Fix][Connector-V2] Ignore JdbcConnectorException on JDBC statement close #9942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dybyte
wants to merge
8
commits into
apache:dev
Choose a base branch
from
dybyte:fix/jdbc-retry
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carl-Zhou-CN
previously approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hisoka-X
reviewed
Oct 15, 2025
...tunnel/connectors/seatunnel/jdbc/internal/executor/InsertOrUpdateBatchStatementExecutor.java
Outdated
Show resolved
Hide resolved
|
Hi @davidzollo, PTAL when you have a moment. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9886
Purpose of this pull request
This PR ignores
JdbcConnectorExceptionthrown during remaining batch execution incloseStatements()and logs the error instead of propagating the exception.When
executeBatch()is called incloseStatements(), aJdbcConnectorExceptionmay occur if the statement is already closed. Ignoring this exception is preferable, as propagating it can cause confusion in upper layers.For more details, please refer to the related issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No additional tests were added for this change.
Check list
New License Guide