Skip to content

Conversation

@dybyte
Copy link
Contributor

@dybyte dybyte commented Oct 13, 2025

Fixes: #9886

Purpose of this pull request

This PR ignores JdbcConnectorException thrown during remaining batch execution in closeStatements() and logs the error instead of propagating the exception.
When executeBatch() is called in closeStatements(), a JdbcConnectorException may occur if the statement is already closed. Ignoring this exception is preferable, as propagating it can cause confusion in upper layers.
For more details, please refer to the related issue.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No additional tests were added for this change.

Check list

Carl-Zhou-CN
Carl-Zhou-CN previously approved these changes Oct 14, 2025
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dybyte dybyte requested a review from Hisoka-X October 23, 2025 05:06
@dybyte dybyte requested a review from Carl-Zhou-CN November 3, 2025 10:21
@dybyte
Copy link
Contributor Author

dybyte commented Nov 3, 2025

Hi @davidzollo, PTAL when you have a moment. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Connector-v2][Jdbc] reconnect logic ineffective when close statements failed

3 participants