-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spark] Support push down v2 filter #4937
Open
Zouxxyy
wants to merge
4
commits into
apache:master
Choose a base branch
from
Zouxxyy:dev/use-v2-filter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...park/paimon-spark-3.2/src/main/scala/org/apache/paimon/spark/PaimonSplitScanBuilder.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.paimon.spark | ||
|
||
import org.apache.paimon.table.KnownSplitsTable | ||
|
||
import org.apache.spark.sql.connector.read.Scan | ||
|
||
class PaimonSplitScanBuilder(table: KnownSplitsTable) extends PaimonScanBuilder(table) { | ||
override def build(): Scan = { | ||
PaimonSplitScan(table, table.splits(), requiredSchema, pushedPaimonPredicates) | ||
} | ||
} |
55 changes: 55 additions & 0 deletions
55
...c/main/scala/org/apache/paimon/spark/catalyst/analysis/expressions/ExpressionHelper.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.paimon.spark.catalyst.analysis.expressions | ||
|
||
import org.apache.paimon.predicate.{Predicate, PredicateBuilder} | ||
import org.apache.paimon.spark.SparkFilterConverter | ||
import org.apache.paimon.types.RowType | ||
|
||
import org.apache.spark.sql.PaimonUtils.{normalizeExprs, translateFilter} | ||
import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression} | ||
|
||
trait ExpressionHelper extends ExpressionHelperBase { | ||
|
||
def convertConditionToPaimonPredicate( | ||
condition: Expression, | ||
output: Seq[Attribute], | ||
rowType: RowType, | ||
ignorePartialFailure: Boolean = false): Option[Predicate] = { | ||
val converter = new SparkFilterConverter(rowType) | ||
val filters = normalizeExprs(Seq(condition), output) | ||
.flatMap(splitConjunctivePredicates(_).flatMap { | ||
f => | ||
val filter = translateFilter(f, supportNestedPredicatePushdown = true) | ||
if (filter.isEmpty && !ignorePartialFailure) { | ||
throw new RuntimeException( | ||
"Exec update failed:" + | ||
s" cannot translate expression to source filter: $f") | ||
} | ||
filter | ||
}) | ||
|
||
val predicates = filters.map(converter.convert(_, ignorePartialFailure)).filter(_ != null) | ||
if (predicates.isEmpty) { | ||
None | ||
} else { | ||
Some(PredicateBuilder.and(predicates: _*)) | ||
} | ||
} | ||
} |
54 changes: 54 additions & 0 deletions
54
...park/paimon-spark-3.2/src/test/scala/org/apache/paimon/spark/sql/PaimonPushDownTest.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.paimon.spark.sql | ||
|
||
import org.apache.spark.sql.catalyst.expressions.{AttributeReference, EqualTo, Expression, Literal} | ||
import org.apache.spark.sql.catalyst.plans.logical.Filter | ||
|
||
class PaimonPushDownTest extends PaimonPushDownTestBase { | ||
|
||
override def checkFilterExists(sql: String): Boolean = { | ||
spark | ||
.sql(sql) | ||
.queryExecution | ||
.optimizedPlan | ||
.find { | ||
case Filter(_: Expression, _) => true | ||
case _ => false | ||
} | ||
.isDefined | ||
} | ||
|
||
override def checkEqualToFilterExists(sql: String, name: String, value: Literal): Boolean = { | ||
spark | ||
.sql(sql) | ||
.queryExecution | ||
.optimizedPlan | ||
.find { | ||
case Filter(c: Expression, _) => | ||
c.find { | ||
case EqualTo(a: AttributeReference, r: Literal) => | ||
a.name.equals(name) && r.equals(value) | ||
case _ => false | ||
}.isDefined | ||
case _ => false | ||
} | ||
.isDefined | ||
} | ||
} |
125 changes: 125 additions & 0 deletions
125
paimon-spark/paimon-spark-3.3/src/main/scala/org/apache/paimon/spark/PaimonScan.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.paimon.spark | ||
|
||
import org.apache.paimon.predicate.Predicate | ||
import org.apache.paimon.table.{BucketMode, FileStoreTable, Table} | ||
import org.apache.paimon.table.source.{DataSplit, Split} | ||
|
||
import org.apache.spark.sql.PaimonUtils.fieldReference | ||
import org.apache.spark.sql.connector.expressions._ | ||
import org.apache.spark.sql.connector.read.{SupportsReportPartitioning, SupportsRuntimeFiltering} | ||
import org.apache.spark.sql.connector.read.partitioning.{KeyGroupedPartitioning, Partitioning, UnknownPartitioning} | ||
import org.apache.spark.sql.sources.{Filter, In} | ||
import org.apache.spark.sql.types.StructType | ||
|
||
import scala.collection.JavaConverters._ | ||
|
||
case class PaimonScan( | ||
table: Table, | ||
requiredSchema: StructType, | ||
filters: Seq[Predicate], | ||
reservedFilters: Seq[Filter], | ||
override val pushDownLimit: Option[Int], | ||
bucketedScanDisabled: Boolean = false) | ||
extends PaimonBaseScan(table, requiredSchema, filters, reservedFilters, pushDownLimit) | ||
with SupportsRuntimeFiltering | ||
with SupportsReportPartitioning { | ||
|
||
def disableBucketedScan(): PaimonScan = { | ||
copy(bucketedScanDisabled = true) | ||
} | ||
|
||
@transient | ||
private lazy val extractBucketTransform: Option[Transform] = { | ||
table match { | ||
case fileStoreTable: FileStoreTable => | ||
val bucketSpec = fileStoreTable.bucketSpec() | ||
if (bucketSpec.getBucketMode != BucketMode.HASH_FIXED) { | ||
None | ||
} else if (bucketSpec.getBucketKeys.size() > 1) { | ||
None | ||
} else { | ||
// Spark does not support bucket with several input attributes, | ||
// so we only support one bucket key case. | ||
assert(bucketSpec.getNumBuckets > 0) | ||
assert(bucketSpec.getBucketKeys.size() == 1) | ||
val bucketKey = bucketSpec.getBucketKeys.get(0) | ||
if (requiredSchema.exists(f => conf.resolver(f.name, bucketKey))) { | ||
Some(Expressions.bucket(bucketSpec.getNumBuckets, bucketKey)) | ||
} else { | ||
None | ||
} | ||
} | ||
|
||
case _ => None | ||
} | ||
} | ||
|
||
private def shouldDoBucketedScan: Boolean = { | ||
!bucketedScanDisabled && conf.v2BucketingEnabled && extractBucketTransform.isDefined | ||
} | ||
|
||
// Since Spark 3.3 | ||
override def outputPartitioning: Partitioning = { | ||
extractBucketTransform | ||
.map(bucket => new KeyGroupedPartitioning(Array(bucket), lazyInputPartitions.size)) | ||
.getOrElse(new UnknownPartitioning(0)) | ||
} | ||
|
||
override def getInputPartitions(splits: Array[Split]): Seq[PaimonInputPartition] = { | ||
if (!shouldDoBucketedScan || splits.exists(!_.isInstanceOf[DataSplit])) { | ||
return super.getInputPartitions(splits) | ||
} | ||
|
||
splits | ||
.map(_.asInstanceOf[DataSplit]) | ||
.groupBy(_.bucket()) | ||
.map { | ||
case (bucket, groupedSplits) => | ||
PaimonBucketedInputPartition(groupedSplits, bucket) | ||
} | ||
.toSeq | ||
} | ||
|
||
// Since Spark 3.2 | ||
override def filterAttributes(): Array[NamedReference] = { | ||
val requiredFields = readBuilder.readType().getFieldNames.asScala | ||
table | ||
.partitionKeys() | ||
.asScala | ||
.toArray | ||
.filter(requiredFields.contains) | ||
.map(fieldReference) | ||
} | ||
|
||
override def filter(filters: Array[Filter]): Unit = { | ||
val converter = new SparkFilterConverter(table.rowType()) | ||
val partitionFilter = filters.flatMap { | ||
case in @ In(attr, _) if table.partitionKeys().contains(attr) => | ||
Some(converter.convert(in)) | ||
case _ => None | ||
} | ||
if (partitionFilter.nonEmpty) { | ||
readBuilder.withFilter(partitionFilter.head) | ||
// set inputPartitions null to trigger to get the new splits. | ||
inputPartitions = null | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we set this true only in spark 3.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to true purely for semantic clarity, and it is not used in spark 3.2 actually, just for compile compatibility, adding a comment.