Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spark] Support push down v2 filter #4937

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[spark] Support push down v2 filter #4937

wants to merge 4 commits into from

Conversation

Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Jan 17, 2025 •
edited
Loading

Purpose

Support push down v2 filter

class PaimonScanBuilder extends SupportsPushDownV2Filters

class PaimonScan extends SupportsRuntimeV2Filtering

Tests

API and Format

Documentation

@Zouxxyy Zouxxyy marked this pull request as draft January 17, 2025 05:09
@Zouxxyy Zouxxyy marked this pull request as ready for review January 17, 2025 05:19
@Zouxxyy Zouxxyy marked this pull request as draft January 17, 2025 07:11
@Zouxxyy Zouxxyy marked this pull request as ready for review January 17, 2025 13:09
@YannByron
Copy link
Contributor

I see SupportsRuntimeV2Filtering is introduced in Spark 3.4, and SupportsPushDownV2Filters in Spark 3.3. After this pr, i guess Spark 3.2 will extend SupportsRuntimeFiltering and SupportsPushDownFilters, Spark 3.3 will extend SupportsRuntimeFiltering and SupportsPushDownV2Filters and other spark versions will extend SupportsRuntimeV2Filtering and SupportsPushDownV2Filters, right? @Zouxxyy

YannByron
YannByron reviewed Feb 6, 2025
View reviewed changes
paimon-spark/paimon-spark-3.2/src/main/scala/org/apache/paimon/spark/PaimonScan.scala Outdated
@@ -35,7 +35,7 @@ case class PaimonScan(
filters: Seq[Predicate],
reservedFilters: Seq[Filter],
override val pushDownLimit: Option[Int],
disableBucketedScan: Boolean = false)
disableBucketedScan: Boolean = true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we set this true only in spark 3.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to true purely for semantic clarity, and it is not used in spark 3.2 actually, just for compile compatibility, adding a comment.

@YannByron
Copy link
Contributor

@Zouxxyy LGTM, just left two comments.

@Zouxxyy
Copy link
Contributor Author

Zouxxyy commented Feb 6, 2025

I see SupportsRuntimeV2Filtering is introduced in Spark 3.4, and SupportsPushDownV2Filters in Spark 3.3. After this pr, i guess Spark 3.2 will extend SupportsRuntimeFiltering and SupportsPushDownFilters, Spark 3.3 will extend SupportsRuntimeFiltering and SupportsPushDownV2Filters and other spark versions will extend SupportsRuntimeV2Filtering and SupportsPushDownV2Filters, right? @Zouxxyy

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannByron YannByron YannByron left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zouxxyy @YannByron