Bump FormDesigner module to JDK 17 and adjust javac task #8387
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
mbien
force-pushed
the
bump-formdesigner-module-lang-level
branch
from
1c0735f to
5c27589
Compare
This was referenced Sep 4, 2025
Member
Author
|
lets try to get this one in during the NB 29 cycle |
Member
Author
|
@jlahoda could you take a look at this? |
lahodaj
approved these changes
Oct 30, 2025
Contributor
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
I think this is a reasonable step. It would be better if we found a way to do it with --release (as it would make it easier to e.g. build with Valhalla to get identity warnings, which I tried), but this is a step in a right direction in any case. Thanks!
Member
Author
oh interesting! I didn't try that so far actually. I did run NB master on a valhalla build for a day though after fixing a Will rebase this PR and merge, thanks for reviewing! |
- FormDesigner needs to access the java.awt.peer package - javac ant task should not set --release in that case since it will fail when --add-exports is used on JDK modules - keep AbsoluteLayout.jar on Java 8 level
mbien
force-pushed
the
bump-formdesigner-module-lang-level
branch
from
5c27589 to
ba99c75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember trying to bump the javac target on
java/forma few times already but it failed since as soon--releasewas set it couldn't find the peer classes anymore. This tries to resolve it.java.awt.peerpackage--releasein that case since it will fail when--add-exportsis used on JDK modulesAbsoluteLayout.jaron Java 8 level@lahodaj would this be the right approach?
meta issue #8813