-
Notifications
You must be signed in to change notification settings - Fork 914
Bump java cluster to javac.release 17 #8809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
45c24c4 to
2f77c6d
Compare
|
LGTM. |
migrate remaining modules of the java cluster from javac source to release flag and consolidate on one version many core modules, including editor, maven, gradle were already using release 17, this migrates the rest. skipped test data, performance module and non trivial upgrades like java.hints.declarative, debugger.jpda.visual and form. removed -Xlint:-options flag since "target value 8 is obsolete and will be removed" won't occur anymore moving away from the java 8 target unlocks JDK optimizations due to the invokedynamic bytecode instruction and javac deprecation warnings release is also safer compared to source/target, we can use newer API etc
|
going to refresh this PR for CI, give it another manual smoke test and merge after that. |
2f77c6d to
fc43432
Compare
|
I think this is good. I see |
|
@lahodaj we could skip |
|
No, if build&test passes, just include even |
|
all green (some of the usual flaky test cases needed a restart), manual smoke test was fine too thanks for the reviews! |
Migrates remaining modules of the java cluster from javac source to
javac.releaseproperty and consolidate on one version.releaseis also safer compared tosource/targetand we can use newer API / language features etcMany core modules, including editor, maven, gradle were already using release 17, this migrates the rest.
module list in `java/*` which already used `release=17` (few used 11) before this change
exceptions/other minor changes:
java.hints.declarative,debugger.jpda.visualandform(Bump FormDesigner module to JDK 17 and adjust javac task #8387).-Xlint:-optionsflag sincetarget value 8 is obsolete and will be removedwon't occur anymoremeta issue: #8813