Add pylint to pre-commit #90

michalslowikowski00 · 2020-11-10T20:32:24Z

Hey folks.
This PR will add Pylint to Kibble pre-commit hooks.
If you don't know what Pylint is here you can read about it

This PR introduces some structure to setup.py by encapsulating some parts of the logic into functions and creating the main function.

* Introduce github actions for CI * fixup! Introduce github actions for CI

Closes: apache#59

Closes: apache#49

This commit refactors the code base to create an installable kibble application. Co-authored-by: Michał Słowikowski <[email protected]>

Add Black to pre-commit and format whole codebase

* Use KibbleConfigParser in setup script * fixup! Use KibbleConfigParser in setup script

turbaszek · 2020-11-10T21:55:32Z

@michalslowikowski00 please rebase, I merged #78 and it introduced a lot of additional code to scan :<

turbaszek · 2020-11-10T21:56:51Z

kibble/api/yaml/kibble.yaml.tmp

+mail:
+  mailhost: localhost
+  mailport: 25
+  sender: Kibble <[email protected]>


We don't need this file. I think if you rebase onto latest main branch then this file should be ignored:
https://github.com/apache/kibble/blob/0a11b51dfa01521a10887556124035107ad1fd80/.gitignore#L2-L3

If not then we should adjust gitignore

Should be fixed now.

turbaszek · 2020-11-10T21:57:46Z

.pre-commit-config.yaml

+    hooks:
+      - id: pylint
+    args:
+      - --max-line-length=11080


Let's use pylintrc file for configuration instead of using args in pre-commit. In this way we will be able to supress some warning temporarily and adjust the tool to our needs

Yea, I am figuring out how RC file works.

…hat.

pylintrc

michalslowikowski00 · 2020-11-14T20:37:25Z

@turbaszek
Have you any idea how to resolve all those conflicts?
https://github.com/apache/kibble/pull/90/checks?check_run_id=1400755394

pylintrc

turbaszek · 2020-11-14T22:26:12Z

@turbaszek
Have you any idea how to resolve all those conflicts?
https://github.com/apache/kibble/pull/90/checks?check_run_id=1400755394

There was missing coma, I committed it. Looks better now

This PR adds Github Action job to run tests on CI & fix a failing test

Co-authored-by: Kaxil Naik <[email protected]>

https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/configuring-issue-templates-for-your-repository#configuring-the-template-chooser The file name should be `config.yml` not `config.ymal`

The paths were incorrect, I think they are from before when they were in a separate repo

This PR replaces cameleCase with snake_case, removes some unused variables and adds some that in some cases may result in run time error.

This PR moved watson, azure, picoapi and git configuration to kibble.ini config file. It fixes also reading ES configuration. In this way all Kibble configuration is in single place.

pylint wip wip, pylint

turbaszek and others added 16 commits October 12, 2020 14:10

Refactor setup.py (apache#48)

a2d61ac

This PR introduces some structure to setup.py by encapsulating some parts of the logic into functions and creating the main function.

Introduce github actions for CI (apache#47)

b371d80

* Introduce github actions for CI * fixup! Introduce github actions for CI

Apply pre-commit checks to all files and make CI green (apache#58)

2002a53

Add Github Action and license badge (apache#60)

9376200

Add and unify license headers (apache#61)

aaae65d

Closes: apache#59

Add dev docker compose (apache#50)

7092e86

Refactor api to be a package (apache#51)

5e18332

Closes: apache#49

Make Kibble a package (apache#67)

edb9a91

This commit refactors the code base to create an installable kibble application. Co-authored-by: Michał Słowikowski <[email protected]>

Add auto-labeler for PRs (apache#68)

340f104

Fix labeler definitions (apache#70)

e4563ca

Add Black to pre-commit (apache#66)

d7f9031

Add Black to pre-commit and format whole codebase

Add kibana dashboard to dokcer-compose (apache#75)

17e6734

Add KibbleConfigParser (apache#74)

2abfcc8

Fix deprecation warning for yaml.load() (apache#82)

4d5f537

Remove ulimits for elasticsearch in docker-compose (apache#80)

5471c07

Use KibbleConfigParser in setup script (apache#83)

6959f3c

* Use KibbleConfigParser in setup script * fixup! Use KibbleConfigParser in setup script

michalslowikowski00 self-assigned this Nov 10, 2020

michalslowikowski00 marked this pull request as draft November 10, 2020 20:52

Add scanners to main repository (apache#78)

0a11b51

turbaszek reviewed Nov 10, 2020

View reviewed changes

GitHub uses main as default branch, so we should obviously look for t…

4884cf5

…hat.

michalslowikowski00 force-pushed the add-pylint-to-precommit branch from 03d94fc to 0ccea20 Compare November 13, 2020 15:51

turbaszek reviewed Nov 13, 2020

View reviewed changes

pylintrc Outdated Show resolved Hide resolved

Refactor setup scripts as kibble cli command (apache#91)

7d70dd5

michalslowikowski00 force-pushed the add-pylint-to-precommit branch from 3b8e148 to 858346c Compare November 14, 2020 21:08

turbaszek reviewed Nov 14, 2020

View reviewed changes

pylintrc Outdated Show resolved Hide resolved

kaxil and others added 6 commits December 13, 2020 13:32

Fix failing test & Run tests on CI (apache#115)

89748e4

This PR adds Github Action job to run tests on CI & fix a failing test

Show colored output for Pytest & Show diff on pre-commits (apache#116)

ea59ae0

Add scan command to run scanners (apache#114)

f3a4b27

Co-authored-by: Kaxil Naik <[email protected]>

Fix name of config.yml in Github Issue Template (apache#117)

b4025c2

https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/configuring-issue-templates-for-your-repository#configuring-the-template-chooser The file name should be `config.yml` not `config.ymal`

Add missing __init__.py file in plugins & cli directory (apache#118)

f042a59

Fix the path for the scanners in scanners/README.md (apache#119)

257992d

The paths were incorrect, I think they are from before when they were in a separate repo

turbaszek mentioned this pull request Dec 13, 2020

Improve code quality of scanners #120

Merged

Improve code quality of scanners (apache#120)

f8d731c

This PR replaces cameleCase with snake_case, removes some unused variables and adds some that in some cases may result in run time error.

turbaszek force-pushed the add-pylint-to-precommit branch from 62289b5 to 75c3a92 Compare December 13, 2020 14:25

github-actions bot removed the area:scanners Scanners related issues label Dec 13, 2020

turbaszek and others added 10 commits December 13, 2020 16:56

Make scanners use kibble.ini instead of config.yaml (apache#122)

e19cf6c

This PR moved watson, azure, picoapi and git configuration to kibble.ini config file. It fixes also reading ES configuration. In this way all Kibble configuration is in single place.

Add pylint to pre-commit

344832b

pylint wip wip, pylint

add pylintrc file

aca8b1d

added suggestion from review

fc72297

Add pylint to pre-commit

99f81fe

pylint wip wip, pylint

add pylintrc file

e874d8b

Update pylintrc

0b7ce3a

fixup! rebase on latest master

232f7be

fixed unused-import

39a5e71

added missing-module-docstring

29d29c7

turbaszek force-pushed the add-pylint-to-precommit branch from 75c3a92 to ca400a1 Compare December 13, 2020 17:12

github-actions bot added area:api area:cli CLI related issues labels Dec 13, 2020

turbaszek force-pushed the add-pylint-to-precommit branch from ca400a1 to 8111d1d Compare December 13, 2020 17:16

Ignore more rules and fix more issues

2a65d75

turbaszek force-pushed the add-pylint-to-precommit branch from 8111d1d to 2a65d75 Compare December 13, 2020 17:19

Run pylint locally

5b612c8

github-actions bot added the area:dev label Dec 14, 2020

turbaszek force-pushed the main branch 2 times, most recently from 2abfcc8 to 113819c Compare January 16, 2021 11:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add pylint to pre-commit #90

Add pylint to pre-commit #90

michalslowikowski00 commented Nov 10, 2020

turbaszek commented Nov 10, 2020

turbaszek Nov 10, 2020

michalslowikowski00 Nov 14, 2020

turbaszek Nov 10, 2020

michalslowikowski00 Nov 13, 2020

michalslowikowski00 commented Nov 14, 2020

turbaszek commented Nov 14, 2020

Add pylint to pre-commit #90

Are you sure you want to change the base?

Add pylint to pre-commit #90

Conversation

michalslowikowski00 commented Nov 10, 2020

turbaszek commented Nov 10, 2020

turbaszek Nov 10, 2020

Choose a reason for hiding this comment

michalslowikowski00 Nov 14, 2020

Choose a reason for hiding this comment

turbaszek Nov 10, 2020

Choose a reason for hiding this comment

michalslowikowski00 Nov 13, 2020

Choose a reason for hiding this comment

michalslowikowski00 commented Nov 14, 2020

turbaszek commented Nov 14, 2020