Ignore more rules and fix more issues

Author: turbaszek

kibble/api/handler.py

@@ -54,6 +54,7 @@
 
 class KibbleHTTPError(Exception):
     def __init__(self, code, message):
+        super().__init__()
         self.code = code
         self.message = message
 
@@ -75,7 +76,7 @@ def __call__(self, environ, start_response, session):
             # Read JSON client data if any
             try:
                 request_size = int(environ.get("CONTENT_LENGTH", 0))
-            except (ValueError):
+            except ValueError:
                 request_size = 0
             requestBody = environ["wsgi.input"].read(request_size)
             formdata = {}
@@ -123,7 +124,7 @@ def __call__(self, environ, start_response, session):
                 ) + "\n"
                 return
 
-        except:
+        except:  # pylint: disable=bare-except
             err_type, err_value, tb = sys.exc_info()
             traceback_output = ["API traceback:"]
             traceback_output += traceback.format_tb(tb)
@@ -133,7 +134,7 @@ def __call__(self, environ, start_response, session):
                 start_response(
                     "500 Internal Server Error", [("Content-Type", "application/json")]
                 )
-            except:
+            except:  # pylint: disable=bare-except
                 pass
             yield json.dumps({"code": "500", "reason": "\n".join(traceback_output)})
 
@@ -142,7 +143,6 @@ def fourohfour(environ, start_response):
     """A very simple 404 handler"""
     start_response("404 Not Found", [("Content-Type", "application/json")])
     yield json.dumps({"code": 404, "reason": "API endpoint not found"}, indent=4) + "\n"
-    return
 
 
 def application(environ, start_response):
@@ -164,7 +164,7 @@ def application(environ, start_response):
                     session.headers.append(bucket)
                     try:
                         start_response("200 Okay", session.headers)
-                    except:
+                    except:  # pylint: disable=bare-except
                         pass
                 a += 1
                 # WSGI prefers byte strings, so convert if regular py3 string

kibble/api/pages/bio/newtimers.py

@@ -75,10 +75,10 @@ def find_earlier(session, query, when, who, which, where, doctype, dOrg):
     if "aggs" in query:
         del query["aggs"]
 
-    rangeQuery = {"range": {which: {"from": 0, "to": time.time()}}}
+    range_query = {"range": {which: {"from": 0, "to": time.time()}}}
 
     query["query"]["bool"]["must"] = [
-        rangeQuery,
+        range_query,
         {"term": {"organisation": dOrg}},
         {"term": {where: who}},
     ]
@@ -90,10 +90,7 @@ def find_earlier(session, query, when, who, which, where, doctype, dOrg):
         doc = res["hits"]["hits"][0]["_source"]
         if doc[which] >= when:
             return [doc[which], doc]
-        else:
-            return [-1, None]
-    else:
-        return [-1, None]
+    return [-1, None]
 
 
 def run(API, environ, indata, session):

kibble/api/pages/ci/queue.py

@@ -65,7 +65,6 @@
 This is the CI queue timeseries renderer for Kibble
 """
 
-import hashlib
 import json
 import time
 

kibble/api/pages/ci/status.py

@@ -65,7 +65,6 @@
 This is the CI queue status (blocked/stuck) timeseries renderer for Kibble
 """
 
-import hashlib
 import json
 import time
 

kibble/api/pages/ci/top-buildcount.py

@@ -66,7 +66,6 @@
 """
 
 import json
-import re
 import time
 
 

kibble/api/pages/ci/top-buildtime.py

@@ -66,7 +66,6 @@
 """
 
 import json
-import re
 import time
 
 

kibble/api/pages/code/commits.py

@@ -65,7 +65,7 @@
 This is the TopN committers list renderer for Kibble
 """
 
-import hashlib
+
 import json
 import time
 

kibble/api/pages/code/evolution.py

@@ -65,7 +65,7 @@
 This is the TopN committers list renderer for Kibble
 """
 
-import hashlib
+
 import json
 import time
 
@@ -119,7 +119,7 @@ def run(API, environ, indata, session):
     )
     sid = res["_scroll_id"]
     scroll_size = res["hits"]["total"]
-    if type(scroll_size) is dict:
+    if isinstance(scroll_size, dict):
         scroll_size = scroll_size["value"]  # ES >= 7.x
 
     timeseries = []

kibble/api/pages/code/pony-timeseries.py

@@ -67,7 +67,6 @@
 
 import datetime
 import json
-import re
 import time
 
 import dateutil.relativedelta

kibble/api/pages/code/pony.py

@@ -66,7 +66,6 @@
 """
 
 import json
-import re
 import time
 
 

kibble/api/pages/code/punchcard.py

@@ -65,7 +65,7 @@
 This is the commit punch-card renderer for Kibble
 """
 
-import hashlib
+
 import json
 import time
 

kibble/api/pages/code/relationships.py

@@ -66,7 +66,6 @@
 """
 
 import copy
-import hashlib
 import json
 import math
 import re
@@ -82,34 +81,34 @@ def run(API, environ, indata, session):
     now = time.time()
 
     # First, fetch the view if we have such a thing enabled
-    viewList = []
+    view_list = []
     if indata.get("view"):
-        viewList = session.getView(indata.get("view"))
+        view_list = session.getView(indata.get("view"))
     if indata.get("subfilter"):
-        viewList = session.subFilter(indata.get("subfilter"), view=viewList)
+        view_list = session.subFilter(indata.get("subfilter"), view=view_list)
 
-    dateTo = indata.get("to", int(time.time()))
-    dateFrom = indata.get(
-        "from", dateTo - (86400 * 30 * 6)
+    date_to = indata.get("to", int(time.time()))
+    date_from = indata.get(
+        "from", date_to - (86400 * 30 * 6)
     )  # Default to a 6 month span
 
-    which = "committer_email"
-    role = "committer"
-    if indata.get("author", False):
-        which = "author_email"
-        role = "author"
+    # which = "committer_email"
+    # role = "committer"
+    # if indata.get("author", False):
+    #     which = "author_email"
+    #     role = "author"
 
     interval = indata.get("interval", "day")
 
     ####################################################################
     ####################################################################
-    dOrg = session.user["defaultOrganisation"] or "apache"
+    d_org = session.user["defaultOrganisation"] or "apache"
     query = {
         "query": {
             "bool": {
                 "must": [
-                    {"range": {"tsday": {"from": dateFrom, "to": dateTo}}},
-                    {"term": {"organisation": dOrg}},
+                    {"range": {"tsday": {"from": date_from, "to": date_to}}},
+                    {"term": {"organisation": d_org}},
                 ]
             }
         }
@@ -119,8 +118,8 @@ def run(API, environ, indata, session):
         query["query"]["bool"]["must"].append(
             {"term": {"sourceID": indata.get("source")}}
         )
-    elif viewList:
-        query["query"]["bool"]["must"].append({"terms": {"sourceID": viewList}})
+    elif view_list:
+        query["query"]["bool"]["must"].append({"terms": {"sourceID": view_list}})
     if indata.get("email"):
         query["query"]["bool"]["must"].append(
             {
@@ -140,16 +139,15 @@ def run(API, environ, indata, session):
 
     repos = {}
     repo_commits = {}
-    authorlinks = {}
     max_commits = 0
     max_links = 0
     max_shared = 0
     max_authors = 0
-    minLinks = indata.get("links", 1)
+    min_links = indata.get("links", 1)
 
     # For each repo, count commits and gather data on authors
     for doc in res["aggregations"]["per_repo"]["buckets"]:
-        sourceID = doc["key"]
+        source_id = doc["key"]
         commits = doc["doc_count"]
 
         # Gather the unique authors/committers
@@ -164,7 +162,7 @@ def run(API, environ, indata, session):
             }
         }
         xquery = copy.deepcopy(query)
-        xquery["query"]["bool"]["must"].append({"term": {"sourceID": sourceID}})
+        xquery["query"]["bool"]["must"].append({"term": {"sourceID": source_id}})
         xres = session.DB.ES.search(
             index=session.DB.dbname, doc_type="code_commit", size=0, body=xquery
         )
@@ -173,8 +171,8 @@ def run(API, environ, indata, session):
             authors.append(person["key"])
         if commits > max_commits:
             max_commits = commits
-        repos[sourceID] = authors
-        repo_commits[sourceID] = commits
+        repos[source_id] = authors
+        repo_commits[source_id] = commits
 
     # Now, figure out which repos share the same contributors
     repo_links = {}
@@ -184,7 +182,6 @@ def run(API, environ, indata, session):
 
     # Grab data of all sources
     for ID, repo in repos.items():
-        mylinks = {}
         if not session.DB.ES.exists(index=session.DB.dbname, doc_type="source", id=ID):
             continue
         repodatas[ID] = session.DB.ES.get(
@@ -193,7 +190,7 @@ def run(API, environ, indata, session):
 
     for ID, repo in repos.items():
         mylinks = {}
-        if not ID in repodatas:
+        if ID not in repodatas:
             continue
         repodata = repodatas[ID]
         oID = ID
@@ -221,7 +218,7 @@ def run(API, environ, indata, session):
                             xlinks.append(author)
                     lname = "%s@%s" % (ID, xID)  # Link name
                     rname = "%s@%s" % (xID, ID)  # Reverse link name
-                    if len(xlinks) >= minLinks and not rname in repo_links:
+                    if len(xlinks) >= min_links and not rname in repo_links:
                         mylinks[xID] = len(xlinks)
                         repo_links[lname] = repo_links.get(lname, 0) + len(
                             xlinks
@@ -255,25 +252,25 @@ def run(API, environ, indata, session):
     nodes = []
     links = []
     existing_repos = []
-    for sourceID in repo_notoriety.keys():
+    for source_id in repo_notoriety:
         lsize = 0
-        for k in repo_links.keys():
+        for k in repo_links:
             fr, to = k.split("@")
-            if fr == sourceID or to == sourceID:
+            if source_id in (fr, to):
                 lsize += 1
-        asize = len(repo_authors[sourceID])
+        asize = len(repo_authors[source_id])
         doc = {
-            "id": sourceID,
-            "name": sourceID,
-            "commits": repo_commits[sourceID],
+            "id": source_id,
+            "name": source_id,
+            "commits": repo_commits[source_id],
             "authors": asize,
             "links": lsize,
             "size": max(5, (1 - abs(math.log10(asize / max_authors))) * 45),
             "tooltip": "%u connections, %u contributors, %u commits"
-            % (lsize, asize, repo_commits[sourceID]),
+            % (lsize, asize, repo_commits[source_id]),
         }
         nodes.append(doc)
-        existing_repos.append(sourceID)
+        existing_repos.append(source_id)
 
     for k, s in repo_links.items():
         size = s

kibble/api/pages/code/retention.py

@@ -67,7 +67,6 @@
 
 import datetime
 import json
-import re
 import time
 
 

kibble/api/pages/code/trends.py

@@ -253,24 +253,5 @@ def run(API, environ, indata, session):
         },
     }
 
-    JSON_OUT = {"trends": trends, "okay": True, "responseTime": time.time() - now}
-    yield json.dumps(JSON_OUT)
-
-
-"""
-commits = {
-                before = pcommits,
-                after = commits,
-                title = "Commits"
-            },
-            [role.."s"] = {
-                before = pcommitters,
-                after = committers,
-                title = role:gsub("^(%S)", string.upper).."s",
-            },
-            lines = {
-                before = pdeletions + pinsertions,
-                after = deletions + insertions,
-                title = "Lines changed"
-            }
-            """
+    json_out = {"trends": trends, "okay": True, "responseTime": time.time() - now}
+    yield json.dumps(json_out)

kibble/api/pages/forum/actors.py

@@ -65,7 +65,7 @@
 This is the forum actors stats page for Kibble
 """
 
-import hashlib
+
 import json
 import time
 

kibble/api/pages/forum/issues.py

@@ -65,7 +65,6 @@
 This is the forum timeseries renderer for Kibble
 """
 
-import hashlib
 import json
 import time
 

kibble/api/pages/forum/top.py

@@ -65,7 +65,7 @@
 This is the issue actors stats page for Kibble
 """
 
-import hashlib
+
 import json
 import time
 

kibble/api/pages/issue/actors.py

@@ -65,7 +65,6 @@
 This is the issue actors stats page for Kibble
 """
 
-import hashlib
 import json
 import time