Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -650,9 +650,24 @@ private void onSuccessResponse(final StreamsGroupHeartbeatResponse response, fin
heartbeatRequestState.updateHeartbeatIntervalMs(data.heartbeatIntervalMs());
heartbeatRequestState.onSuccessfulAttempt(currentTimeMs);
heartbeatState.setEndpointInformationEpoch(data.endpointInformationEpoch());
streamsRebalanceData.setHeartbeatIntervalMs(data.heartbeatIntervalMs());
streamsRebalanceData.setTaskOffsetIntervalMs(data.taskOffsetIntervalMs());
streamsRebalanceData.setAcceptableRecoveryLag(data.acceptableRecoveryLag());
// A leaving member's response carries no group configuration (the fields hold protocol defaults), so do not
// log or store it while shutting down. Normal responses have memberEpoch >= 0; leave responses use the
// negative leave sentinels (fenced members take the error path instead). Log only when a value changes, to
// avoid repeating it on every heartbeat: this fires on first receipt (values start unset) and on any later change.
if (data.memberEpoch() >= 0) {
if (data.heartbeatIntervalMs() != streamsRebalanceData.heartbeatIntervalMs()
|| data.taskOffsetIntervalMs() != streamsRebalanceData.taskOffsetIntervalMs()
|| data.acceptableRecoveryLag() != streamsRebalanceData.acceptableRecoveryLag()) {
logger.info("Received Streams group configuration from the group coordinator: "
+ "heartbeatIntervalMs={}, taskOffsetIntervalMs={}, acceptableRecoveryLag={}",
describeConfig(data.heartbeatIntervalMs(), 1),
describeConfig(data.taskOffsetIntervalMs(), 1),
describeConfig(data.acceptableRecoveryLag(), 0));
}
streamsRebalanceData.setHeartbeatIntervalMs(data.heartbeatIntervalMs());
streamsRebalanceData.setTaskOffsetIntervalMs(data.taskOffsetIntervalMs());
streamsRebalanceData.setAcceptableRecoveryLag(data.acceptableRecoveryLag());
}

if (data.topologyDescriptionRequired() && streamsRebalanceData.wireTopologyDescription() != null) {
logger.info("Broker requested topology description push");
Expand All @@ -677,6 +692,13 @@ private void onSuccessResponse(final StreamsGroupHeartbeatResponse response, fin
membershipManager.onHeartbeatSuccess(response);
}

// Renders a coordinator-provided config value for logging, or a note when the broker did not provide it. An older
// broker leaves these at their protocol defaults (intervals 0, acceptableRecoveryLag -1); a value below minValid
// means "not provided".
private static String describeConfig(final long value, final long minValid) {
return value < minValid ? "not provided (older broker)" : Long.toString(value);
}

private void onErrorResponse(final StreamsGroupHeartbeatResponse response, final long currentTimeMs) {
final Errors error = Errors.forCode(response.data().errorCode());
final String errorMessage = response.data().errorMessage();
Expand Down
Loading
Loading