MINOR: Kafka Streams should log broker provided KIP-1071 config values#22730
Open
mjsax wants to merge 1 commit into
Open
MINOR: Kafka Streams should log broker provided KIP-1071 config values#22730mjsax wants to merge 1 commit into
mjsax wants to merge 1 commit into
Conversation
In the "streams" protocol, certain configs moved from the client to the broker, and the broker provides some of these configs to the client via the heartbeat response. The client should log these values for better client-side observability.
mjsax
commented
Jul 2, 2026
| } | ||
|
|
||
| @Test | ||
| public void testTaskOffsetsReportedForStandbyAndWarmupTasks() { |
Member
Author
There was a problem hiding this comment.
This test is not directly related to this PR, but closes an existing test gap -- I just added it to avoid opening an extra PR. Hope that's ok. :)
mjsax
commented
Jul 2, 2026
| } | ||
|
|
||
| @Test | ||
| public void testTaskOffsetReportingCadenceConditionsInterplay() { |
Member
Author
There was a problem hiding this comment.
Same. Just closing an existing testing gap.
mjsax
commented
Jul 2, 2026
| } | ||
|
|
||
| @Test | ||
| public void testStreamsRebalanceDataTaskOffsetIntervalMsUpdatedOnSuccess() { |
mjsax
changed the title
mjsax
added
KIP-1071
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the "streams" protocol, certain configs moved from the client to the
broker, and the broker provides some of these configs to the client via
the heartbeat response. The client should log these values for better
client-side observability.