KAFKA-19345: Use ShareFetchUtils mock for DelayedShareFetchTest tests #20765
+200
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandboat
changed the title
brandboat
changed the title
brandboat
commented
Oct 24, 2025
| assertNull(shareGroupMetrics.topicPartitionsFetchRatio(groupId)); | ||
|
|
||
| delayedShareFetch.lock().unlock(); | ||
| Mockito.verify(exceptionHandler, never()).accept(any(), any()); |
There was a problem hiding this comment.
exceptionHandler shouldn't be triggered in this test case.
The reason it throw error simply due to incorrect test mock up,
replicaManager.getPartitionOrException(tp0.topicPartition()) defined in
, which make isMinBytesSatisfied raise NPE
, and this is unexpected.
brandboat
commented
Oct 24, 2025
| assertTrue(delayedShareFetch.lock().tryLock()); | ||
| delayedShareFetch.lock().unlock(); | ||
| Mockito.verify(exceptionHandler, times(1)).accept(any(), any()); | ||
| Mockito.verify(exceptionHandler, never()).accept(any(), any()); |
|
UserQuotaTest#testThrottledRequest(String) with groupProtocol=classic is a known flaky test (KAFKA-8459). It’s unrelated to this PR and passes locally. |
|
Gentle ping , @AndrewJSchofield, @apoorvmittal10, @adixitconfluent — sorry for the late implementation 🙏 |
|
@adixitconfluent Can you please review the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch wraps ShareFetchUtils static method
processFetchResponsewith MockedStatic to improve test isolation and also fixes some
incorrect test results.