MINOR: suppress build warning (#20424)

mjsax · web-flow · commit 342a8e677340 · 2025-09-01T11:12:11.000-07:00
Suppress build warning.

Reviewers: TengYao Chi &lt;frankvicky@apache.org&gt;, Ken Huang
&lt;s7133700@gmail.com&gt;, Chia-Ping Tsai &lt;chia7712@gmail.com&gt;
diff --git a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientsTestUtils.java b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/ClientsTestUtils.java
@@ -311,7 +311,7 @@ public static <K, V> void sendAndAwaitAsyncCommit(
         Optional<Map<TopicPartition, OffsetAndMetadata>> offsetsOpt
     ) throws InterruptedException {
 
-        var commitCallback = new RetryCommitCallback(consumer, offsetsOpt);
+        var commitCallback = new RetryCommitCallback<>(consumer, offsetsOpt);
         sendAsyncCommit(consumer, commitCallback, offsetsOpt);
 
         TestUtils.waitForCondition(() -> {
diff --git a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/MetricsDuringTopicCreationDeletionTest.java
@@ -137,6 +137,7 @@ private void createAndDeleteTopics() {
         }
     }
 
+    @SuppressWarnings("unchecked")
     private Gauge<Integer> getGauge(String metricName) {
         return KafkaYammerMetrics.defaultRegistry().allMetrics().entrySet().stream()
             .filter(entry -> entry.getKey().getName().endsWith(metricName))
diff --git a/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ClientTelemetryTest.java b/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ClientTelemetryTest.java
@@ -123,6 +123,7 @@ public void testClientInstanceId(ClusterInstance clusterInstance) throws Interru
         }
     }
 
+    @SuppressWarnings("unchecked")
     @ClusterTest(types = {Type.CO_KRAFT, Type.KRAFT})
     public void testIntervalMsParser(ClusterInstance clusterInstance) {
         List<String> alterOpts = asList("--bootstrap-server", clusterInstance.bootstrapServers(),
@@ -152,6 +153,7 @@ public void testMetrics(ClusterInstance clusterInstance) {
         }
     }
 
+    @SuppressWarnings("unchecked")
     private static String[] toArray(List<String>... lists) {
         return Stream.of(lists).flatMap(List::stream).toArray(String[]::new);
     }
diff --git a/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTestUtils.java b/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTestUtils.java
@@ -168,6 +168,7 @@ public static void assertAssignment(boolean expectFailed,
                 "Wrong rebalance delay in " + assignment);
     }
 
+    @SuppressWarnings("unchecked")
     public static <T, R extends ConnectRecord<R>> TransformationChain<T, R> getTransformationChain(
             RetryWithToleranceOperator<T> toleranceOperator,
             List<Object> results) {
diff --git a/core/src/test/java/kafka/server/share/DelayedShareFetchTest.java b/core/src/test/java/kafka/server/share/DelayedShareFetchTest.java
@@ -1278,6 +1278,7 @@ public void testOnCompleteExecutionOnTimeout() {
         assertEquals(1, delayedShareFetch.expiredRequestMeter().count());
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     public void testRemoteStorageFetchTryCompleteReturnsFalse() {
         ReplicaManager replicaManager = mock(ReplicaManager.class);
@@ -1357,6 +1358,7 @@ public void testRemoteStorageFetchTryCompleteReturnsFalse() {
         delayedShareFetch.lock().unlock();
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     public void testRemoteStorageFetchPartitionLeaderChanged() {
         ReplicaManager replicaManager = mock(ReplicaManager.class);
@@ -1421,6 +1423,7 @@ public void testRemoteStorageFetchPartitionLeaderChanged() {
         delayedShareFetch.lock().unlock();
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     public void testRemoteStorageFetchTryCompleteThrowsException() {
         ReplicaManager replicaManager = mock(ReplicaManager.class);
@@ -1507,6 +1510,7 @@ public void testRemoteStorageFetchTryCompleteThrowsException() {
         delayedShareFetch.lock().unlock();
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     public void testRemoteStorageFetchTryCompletionDueToBrokerBecomingOffline() {
         ReplicaManager replicaManager = mock(ReplicaManager.class);
@@ -2197,6 +2201,7 @@ private static BiConsumer<SharePartitionKey, Throwable> mockExceptionHandler() {
         return mock(BiConsumer.class);
     }
 
+    @SuppressWarnings("unchecked")
     static class DelayedShareFetchBuilder {
         private ShareFetch shareFetch = mock(ShareFetch.class);
         private ReplicaManager replicaManager = mock(ReplicaManager.class);
diff --git a/core/src/test/java/kafka/server/share/SharePartitionManagerTest.java b/core/src/test/java/kafka/server/share/SharePartitionManagerTest.java
@@ -2470,7 +2470,6 @@ public void testSharePartitionInitializationExceptions() throws Exception {
     }
 
     @Test
-    @SuppressWarnings("unchecked")
     public void testShareFetchProcessingExceptions() throws Exception {
         String groupId = "grp";
         TopicIdPartition tp0 = new TopicIdPartition(Uuid.randomUuid(), new TopicPartition("foo", 0));
@@ -3232,6 +3231,7 @@ Compression.NONE, new SimpleRecord("test-key".getBytes(), "test-value".getBytes(
         return CollectionConverters.asScala(logReadResults).toSeq();
     }
 
+    @SuppressWarnings("unchecked")
     static void mockReplicaManagerDelayedShareFetch(ReplicaManager replicaManager,
                                                     DelayedOperationPurgatory<DelayedShareFetch> delayedShareFetchPurgatory) {
         doAnswer(invocationOnMock -> {
diff --git a/core/src/test/java/kafka/server/share/SharePartitionTest.java b/core/src/test/java/kafka/server/share/SharePartitionTest.java
@@ -110,6 +110,7 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+@SuppressWarnings("resource")
 public class SharePartitionTest {
 
     private static final String ACQUISITION_LOCK_NEVER_GOT_RELEASED = "Acquisition lock never got released.";
@@ -7991,6 +7992,7 @@ public void testAcquireWithReadCommittedIsolationLevel() {
         assertNotNull(sharePartition.cachedState().get(50L).offsetState().get(69L).acquisitionLockTimeoutTask());
     }
 
+    @SuppressWarnings({"rawtypes", "unchecked"})
     @Test
     public void testContainsAbortMarker() {
         SharePartition sharePartition = SharePartitionBuilder.builder()
diff --git a/metadata/src/test/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsTest.java b/metadata/src/test/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsTest.java
@@ -160,6 +160,7 @@ public void testControlledShutdownCountMetric() {
         );
     }
 
+    @SuppressWarnings("unchecked") // suppress warning about Gauge typecast
     @Test
     public void testBrokerRegistrationStateMetrics() {
         MetricsRegistry registry = new MetricsRegistry();
diff --git a/metadata/src/test/java/org/apache/kafka/controller/metrics/QuorumControllerMetricsTest.java b/metadata/src/test/java/org/apache/kafka/controller/metrics/QuorumControllerMetricsTest.java
@@ -164,6 +164,7 @@ public void testLastAppliedRecordMetrics() {
         }
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     public void testTimeSinceLastHeartbeatReceivedMs() {
         MetricsRegistry registry = new MetricsRegistry();
diff --git a/server-common/src/test/java/org/apache/kafka/server/util/CommandLineUtilsTest.java b/server-common/src/test/java/org/apache/kafka/server/util/CommandLineUtilsTest.java
@@ -55,35 +55,35 @@ public void testParseEmptyArgAsValid() {
         List<String> argArray = List.of("my.empty.property=", "my.empty.property1");
         Properties props = CommandLineUtils.parseKeyValueArgs(argArray);
 
-        assertEquals(props.getProperty("my.empty.property"), "", "Value of a key with missing value should be an empty string");
-        assertEquals(props.getProperty("my.empty.property1"), "", "Value of a key with missing value with no delimiter should be an empty string");
+        assertEquals("", props.getProperty("my.empty.property"), "Value of a key with missing value should be an empty string");
+        assertEquals("", props.getProperty("my.empty.property1"), "Value of a key with missing value with no delimiter should be an empty string");
     }
 
     @Test
     public void testParseSingleArg() {
         List<String> argArray = List.of("my.property=value");
         Properties props = CommandLineUtils.parseKeyValueArgs(argArray);
 
-        assertEquals(props.getProperty("my.property"), "value", "Value of a single property should be 'value'");
+        assertEquals("value", props.getProperty("my.property"), "Value of a single property should be 'value'");
     }
 
     @Test
     public void testParseArgs() {
         List<String> argArray = List.of("first.property=first", "second.property=second");
         Properties props = CommandLineUtils.parseKeyValueArgs(argArray);
 
-        assertEquals(props.getProperty("first.property"), "first", "Value of first property should be 'first'");
-        assertEquals(props.getProperty("second.property"), "second", "Value of second property should be 'second'");
+        assertEquals("first", props.getProperty("first.property"), "Value of first property should be 'first'");
+        assertEquals("second", props.getProperty("second.property"), "Value of second property should be 'second'");
     }
 
     @Test
     public void testParseArgsWithMultipleDelimiters() {
         List<String> argArray = List.of("first.property==first", "second.property=second=", "third.property=thi=rd");
         Properties props = CommandLineUtils.parseKeyValueArgs(argArray);
 
-        assertEquals(props.getProperty("first.property"), "=first", "Value of first property should be '=first'");
-        assertEquals(props.getProperty("second.property"), "second=", "Value of second property should be 'second='");
-        assertEquals(props.getProperty("third.property"), "thi=rd", "Value of second property should be 'thi=rd'");
+        assertEquals("=first", props.getProperty("first.property"), "Value of first property should be '=first'");
+        assertEquals("second=", props.getProperty("second.property"), "Value of second property should be 'second='");
+        assertEquals("thi=rd", props.getProperty("third.property"), "Value of second property should be 'thi=rd'");
     }
 
     Properties props = new Properties();
@@ -272,6 +272,7 @@ public void testInitializeBootstrapPropertiesWithBothBootstraps() {
                     Optional.of("127.0.0.2:9094"), Optional.of("127.0.0.3:9095"))).getMessage());
     }
 
+    @SuppressWarnings("unchecked")
     private OptionSpec<String> createMockOptionSpec(String name) {
         OptionSpec<String> spec = mock(OptionSpec.class);
         when(spec.toString()).thenReturn("[" + name.replaceAll("--", "") + "]");
diff --git a/server/src/test/java/org/apache/kafka/server/quota/ClientQuotasRequestTest.java b/server/src/test/java/org/apache/kafka/server/quota/ClientQuotasRequestTest.java
@@ -479,6 +479,7 @@ public void testDescribeClientQuotasMatchExact() throws ExecutionException, Inte
         }
     }
 
+    @SuppressWarnings("unchecked")
     private void testMatchEntities(ClientQuotaFilter filter, int expectedMatchSize, Predicate<ClientQuotaEntity> partition)
         throws InterruptedException {
         TestUtils.retryOnExceptionWithTimeout(5000L, () -> {
diff --git a/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java b/storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java
@@ -60,6 +60,7 @@
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
+@SuppressWarnings("resource")
 @ClusterTestDefaults(brokers = 3)
 public class TopicBasedRemoteLogMetadataManagerTest {
     private static final int SEG_SIZE = 1048576;
@@ -106,6 +107,7 @@ public void testTopicDoesNotExist() throws ExecutionException, InterruptedExcept
         }
     }
 
+    @SuppressWarnings("unchecked")
     @ClusterTest
     public void testDoesTopicExistWithAdminClientExecutionError() throws ExecutionException, InterruptedException {
         // Create a mock Admin client that throws an ExecutionException (not UnknownTopicOrPartitionException)
diff --git a/storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java b/storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java
@@ -381,6 +381,7 @@ void testRemoteStorageManagerWithUserDefinedConfigs() {
         assertFalse(remoteStorageManagerConfig.containsKey("remote.storage.manager.y"));
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     void testRemoteLogMetadataManagerWithEndpointConfig() {
         ArgumentCaptor<Map<String, Object>> capture = ArgumentCaptor.forClass(Map.class);
@@ -391,6 +392,7 @@ void testRemoteLogMetadataManagerWithEndpointConfig() {
         assertEquals(brokerId, capture.getValue().get(ServerConfigs.BROKER_ID_CONFIG));
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     void testRemoteLogMetadataManagerWithEndpointConfigOverridden() throws IOException {
         Properties props = new Properties();
@@ -430,6 +432,7 @@ public RemoteLogMetadataManager createRemoteLogMetadataManager() {
         }
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     void testConfigure() {
         ArgumentCaptor<Map<String, Object>> capture = ArgumentCaptor.forClass(Map.class);
@@ -2071,6 +2074,7 @@ public void testCandidateLogSegmentsSkipsSegmentsAfterLastStableOffset() {
         assertEquals(expected, actual);
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     public void testRemoteSizeData() {
         Supplier<RemoteLogManager.RetentionSizeData>[] invalidRetentionSizeData =
@@ -2087,6 +2091,7 @@ public void testRemoteSizeData() {
         }
     }
 
+    @SuppressWarnings("unchecked")
     @Test
     public void testRemoteSizeTime() {
         Supplier<RemoteLogManager.RetentionTimeData>[] invalidRetentionTimeData =
diff --git a/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java b/streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java
@@ -1961,6 +1961,7 @@ public void configure(final Map<String, ?> configs) {
 
                     }
 
+                    @SuppressWarnings("deprecation")
                     @Override
                     public ProductionExceptionHandlerResponse handle(final ErrorHandlerContext context, final ProducerRecord<byte[], byte[]> record, final Exception exception) {
                         sourceRawData[0] = context.sourceRawKey();
@@ -1978,15 +1979,14 @@ public ProductionExceptionHandlerResponse handle(final ErrorHandlerContext conte
         assertNull(sourceRawData[1]);
     }
 
-
     @Test
     public void shouldHaveRawDataDuringExceptionInSerialization() {
         final byte[][] sourceRawData = new byte[][]{new byte[]{}, new byte[]{}};
         try (final ErrorStringSerializer errorSerializer = new ErrorStringSerializer()) {
             final RecordCollector collector = newRecordCollector(
                     new ProductionExceptionHandler() {
+                        @SuppressWarnings({"deprecation", "rawtypes"})
                         @Override
-                        @SuppressWarnings({"rawtypes", "unused"})
                         public ProductionExceptionHandlerResponse handleSerializationException(final ErrorHandlerContext context, final ProducerRecord record, final Exception exception, final SerializationExceptionOrigin origin) {
                             sourceRawData[0] = context.sourceRawKey();
                             sourceRawData[1] = context.sourceRawValue();

Original file line number	Diff line number	Diff line change
`@@ -137,6 +137,7 @@ private void createAndDeleteTopics() {`
`137`	`137`	`}`
`138`	`138`	`}`
`139`	`139`
	`140`	`+ @SuppressWarnings("unchecked")`
`140`	`141`	`private Gauge<Integer> getGauge(String metricName) {`
`141`	`142`	`return KafkaYammerMetrics.defaultRegistry().allMetrics().entrySet().stream()`
`142`	`143`	`.filter(entry -> entry.getKey().getName().endsWith(metricName))`
Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,7 @@ public void testClientInstanceId(ClusterInstance clusterInstance) throws Interru`
`123`	`123`	`}`
`124`	`124`	`}`
`125`	`125`
	`126`	`+ @SuppressWarnings("unchecked")`
`126`	`127`	`@ClusterTest(types = {Type.CO_KRAFT, Type.KRAFT})`
`127`	`128`	`public void testIntervalMsParser(ClusterInstance clusterInstance) {`
`128`	`129`	`List<String> alterOpts = asList("--bootstrap-server", clusterInstance.bootstrapServers(),`
`@@ -152,6 +153,7 @@ public void testMetrics(ClusterInstance clusterInstance) {`
`152`	`153`	`}`
`153`	`154`	`}`
`154`	`155`
	`156`	`+ @SuppressWarnings("unchecked")`
`155`	`157`	`private static String[] toArray(List<String>... lists) {`
`156`	`158`	`return Stream.of(lists).flatMap(List::stream).toArray(String[]::new);`
`157`	`159`	`}`
Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,7 @@ public static void assertAssignment(boolean expectFailed,`
`168`	`168`	`"Wrong rebalance delay in " + assignment);`
`169`	`169`	`}`
`170`	`170`
	`171`	`+ @SuppressWarnings("unchecked")`
`171`	`172`	`public static <T, R extends ConnectRecord<R>> TransformationChain<T, R> getTransformationChain(`
`172`	`173`	`RetryWithToleranceOperator<T> toleranceOperator,`
`173`	`174`	`List<Object> results) {`
Original file line number	Diff line number	Diff line change
`@@ -2470,7 +2470,6 @@ public void testSharePartitionInitializationExceptions() throws Exception {`
`2470`	`2470`	`}`
`2471`	`2471`
`2472`	`2472`	`@Test`
`2473`		`- @SuppressWarnings("unchecked")`
`2474`	`2473`	`public void testShareFetchProcessingExceptions() throws Exception {`
`2475`	`2474`	`String groupId = "grp";`
`2476`	`2475`	`TopicIdPartition tp0 = new TopicIdPartition(Uuid.randomUuid(), new TopicPartition("foo", 0));`
`@@ -3232,6 +3231,7 @@ Compression.NONE, new SimpleRecord("test-key".getBytes(), "test-value".getBytes(`
`3232`	`3231`	`return CollectionConverters.asScala(logReadResults).toSeq();`
`3233`	`3232`	`}`
`3234`	`3233`
	`3234`	`+ @SuppressWarnings("unchecked")`
`3235`	`3235`	`static void mockReplicaManagerDelayedShareFetch(ReplicaManager replicaManager,`
`3236`	`3236`	`DelayedOperationPurgatory<DelayedShareFetch> delayedShareFetchPurgatory) {`
`3237`	`3237`	`doAnswer(invocationOnMock -> {`
Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,7 @@ public void testControlledShutdownCountMetric() {`
`160`	`160`	`);`
`161`	`161`	`}`
`162`	`162`
	`163`	`+ @SuppressWarnings("unchecked") // suppress warning about Gauge typecast`
`163`	`164`	`@Test`
`164`	`165`	`public void testBrokerRegistrationStateMetrics() {`
`165`	`166`	`MetricsRegistry registry = new MetricsRegistry();`
Original file line number	Diff line number	Diff line change
`@@ -164,6 +164,7 @@ public void testLastAppliedRecordMetrics() {`
`164`	`164`	`}`
`165`	`165`	`}`
`166`	`166`
	`167`	`+ @SuppressWarnings("unchecked")`
`167`	`168`	`@Test`
`168`	`169`	`public void testTimeSinceLastHeartbeatReceivedMs() {`
`169`	`170`	`MetricsRegistry registry = new MetricsRegistry();`