Docs: Add rewrite-table-path in spark procedure #12115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyrain
reviewed
Jan 27, 2025
flyrain
reviewed
Jan 27, 2025
|
thank you @flyrain @RussellSpitzer for the promptly review, updated per your suggestion! |
singhpk234
reviewed
Jan 28, 2025
Co-authored-by: Russell Spitzer <[email protected]>
Co-authored-by: Russell Spitzer <[email protected]>
|
thank you Russell for the detailed review! This is getting closer and I did a local check to ensure the info and warning section rendered as expected like in following screenshot. |
szehon-ho
reviewed
Feb 3, 2025
szehon-ho
reviewed
Feb 6, 2025
flyrain
reviewed
Feb 7, 2025
flyrain
approved these changes
Feb 7, 2025
Co-authored-by: Yufei Gu <[email protected]>
|
With #11929 merged, I can remove the warning in the documentation for table with statistics files |
szehon-ho
reviewed
Feb 8, 2025
manuzhang
reviewed
Feb 8, 2025
| ## Table Replication | ||
|
|
||
| The `rewrite-table-path` procedure prepares an Iceberg table for moving or copying to another location. |
There was a problem hiding this comment.
How can we achieve moving with this procedure?
manuzhang
reviewed
Feb 8, 2025
| Stages a copy of the Iceberg table's metadata files where every absolute path source prefix is replaced by the specified target prefix. | ||
| This can be the starting point to fully or incrementally copy an Iceberg table located under an absolute path under a | ||
| source prefix to another under the target prefix. |
There was a problem hiding this comment.
"under an absolute path under a source prefix to another under the target prefix." is not easy to grok.
manuzhang
reviewed
Feb 8, 2025
|
|
||
| !!! info | ||
| This procedure only prepares metadata or/and data files for an existing Iceberg table for copying or moving to a new location. |
There was a problem hiding this comment.
Data files here means delete files, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for #11931 #11555
I took wording and docs with original author of @flyrain and @szehon-ho
Also @manuzhang is interested in this and wondering if @amogh-jahagirdar is ready to take this as part of 1.8