Add drop_view to the rest catalog #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ndrluis
force-pushed
the
drop-view-rest
branch
2 times, most recently
from
11a5fd4 to
6db3355
Compare
sungwy
reviewed
Aug 29, 2024
pyiceberg/catalog/rest.py
Outdated
Comment on lines
391
to
393
| return {"namespace": NAMESPACE_SEPARATOR.join(identifier.namespace.root[1:]), "table": identifier.name} | ||
| else: | ||
| return {"namespace": NAMESPACE_SEPARATOR.join(identifier.namespace.root), "table": identifier.name} |
There was a problem hiding this comment.
The view identifier is also of TableIdentifier type, so I think this would be safer, and future proof (for when we support loading views):
Suggested change
| return {"namespace": NAMESPACE_SEPARATOR.join(identifier.namespace.root[1:]), "table": identifier.name} | |
| else: | |
| return {"namespace": NAMESPACE_SEPARATOR.join(identifier.namespace.root), "table": identifier.name} | |
| return {"namespace": NAMESPACE_SEPARATOR.join(identifier.namespace.root[1:]), kind: identifier.name} | |
| else: | |
| return {"namespace": NAMESPACE_SEPARATOR.join(identifier.namespace.root), kind: identifier.name} |
pyiceberg/catalog/rest.py
Outdated
| return identifier_tuple | ||
|
|
||
| def _split_identifier_for_path(self, identifier: Union[str, Identifier, TableIdentifier]) -> Properties: | ||
| def _split_identifier_for_path(self, identifier: Union[str, Identifier, TableIdentifier], kind: str = "table") -> Properties: |
There was a problem hiding this comment.
nit: Should we introduce an enum instead of free form strings for the table kind? (table, view, there may be more kinds in the future like materialized views)
|
@sungwy, thank you for your review. I will work on this tomorrow! |
This change allows for the validation of both Tables and Views.
ndrluis
force-pushed
the
drop-view-rest
branch
from
6db3355 to
6a07478
Compare
|
@sungwy Done! |
sungwy
approved these changes
Aug 31, 2024
|
LGTM! Thank you for adding this new API @ndrluis |
2 tasks
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Use NoSuchIdentifier instead of NoTableIdentifier This change allows for the validation of both Tables and Views. * Add drop_view to the rest catalog * fixup! Add drop_view to the rest catalog
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
* Use NoSuchIdentifier instead of NoTableIdentifier This change allows for the validation of both Tables and Views. * Add drop_view to the rest catalog * fixup! Add drop_view to the rest catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.