Add `view_exists` method to REST Catalog #1242

shiv-io · 2024-10-20T19:48:45Z

Part of the adding view support to the REST catalog: #818

Todo:

Add tests
Add docs

Please let me know what the appropriate place to add docs would be

shiv-io · 2024-10-20T22:33:26Z

When I tested catalog.view_exists('default.bar') with a local REST catalog, I got the following exception. This also occurs with the existing catalog.table_exists() method. Is this expected?

from pyiceberg.catalog.rest import RestCatalog

catalog = RestCatalog(
    name='local',
    **{
        'uri': 'http://0.0.0.0:8181'
    }
)

catalog.view_exists('default.bar')

# Traceback (most recent call last):
#   File "/Users/shivgupta/projects/iceberg-python/pyiceberg/catalog/rest.py", line 916, in view_exists
#     response.raise_for_status()
#   File "/Users/shivgupta/projects/iceberg-python/venv/lib/python3.9/site-packages/requests/models.py", line 1024, in raise_for_status
#     raise HTTPError(http_error_msg, response=self)
# requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://0.0.0.0:8181/v1/namespaces/default/views/bar

# The above exception was the direct cause of the following exception:

# Traceback (most recent call last):
#   File "<stdin>", line 1, in <module>
#   File "/Users/shivgupta/projects/iceberg-python/venv/lib/python3.9/site-packages/tenacity/__init__.py", line 336, in wrapped_f
#     return copy(f, *args, **kw)
#   File "/Users/shivgupta/projects/iceberg-python/venv/lib/python3.9/site-packages/tenacity/__init__.py", line 475, in __call__
# >>> catalog.view_exists('default.bar')
# Traceback (most recent call last):
#   File "/Users/shivgupta/projects/iceberg-python/pyiceberg/catalog/rest.py", line 916, in view_exists
#     response.raise_for_status()
#   File "/Users/shivgupta/projects/iceberg-python/venv/lib/python3.9/site-packages/requests/models.py", line 1024, in raise_for_status
#     raise HTTPError(http_error_msg, response=self)
# requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://0.0.0.0:8181/v1/namespaces/default/views/bar

# The above exception was the direct cause of the following exception:

# Traceback (most recent call last):
#   File "<stdin>", line 1, in <module>
#   File "/Users/shivgupta/projects/iceberg-python/venv/lib/python3.9/site-packages/tenacity/__init__.py", line 336, in wrapped_f
#     return copy(f, *args, **kw)
#   File "/Users/shivgupta/projects/iceberg-python/venv/lib/python3.9/site-packages/tenacity/__init__.py", line 475, in __call__
#     do = self.iter(retry_state=retry_state)
#   File "/Users/shivgupta/projects/iceberg-python/venv/lib/python3.9/site-packages/tenacity/__init__.py", line 376, in iter
#     result = action(retry_state)
#   File "/Users/shivgupta/projects/iceberg-python/venv/lib/python3.9/site-packages/tenacity/__init__.py", line 398, in <lambda>
#     self._add_action_func(lambda rs: rs.outcome.result())
#   File "/Users/shivgupta/.pyenv/versions/3.9.16/lib/python3.9/concurrent/futures/_base.py", line 439, in result
#     return self.__get_result()
#   File "/Users/shivgupta/.pyenv/versions/3.9.16/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
#     raise self._exception
#   File "/Users/shivgupta/projects/iceberg-python/venv/lib/python3.9/site-packages/tenacity/__init__.py", line 478, in __call__
#     result = fn(*args, **kwargs)
#   File "/Users/shivgupta/projects/iceberg-python/pyiceberg/catalog/rest.py", line 918, in view_exists
#     self._handle_non_200_response(exc, {})
#   File "/Users/shivgupta/projects/iceberg-python/pyiceberg/catalog/rest.py", line 472, in _handle_non_200_response
#     raise exception(response) from exc
# pyiceberg.exceptions.BadRequestError: RESTError 400: Could not decode json payload:

Note, I used the tabulario/iceberg-rest image to spin up a REST catalog server locally

sungwy · 2024-10-26T00:23:56Z

Hi @shiv-io - thank you for putting together this PR!

When I tested catalog.view_exists('default.bar') with a local REST catalog, I got the following exception. This also occurs with the existing catalog.table_exists() method. Is this expected?

Yes, we have seen issues with specific implementations of the REST Catalog exhibiting issues with certain endpoints. Which REST Catalog implementation/image are you using to run your local test?

shiv-io · 2024-10-26T01:33:12Z

@sungwy I used tabulario/iceberg-rest image to spin up a REST catalog server locally to test with

sungwy

Got it @shiv-io . Unfortunately the tabular REST catalog image doesn't expose the View endpoints. I have WIP PR to address this issue in our test suite, and update our integration test suite to use a REST Catalog image that has newer endpoints implemented.

However, I think the view_exists endpoint is simple enough to test through mocked unit tests and merge. I think your implementation looks good - could we lint and include docs to the API docs?

sungwy · 2024-10-30T13:02:33Z

tests/catalog/test_rest.py

+    namespace = "examples"
+    view = "some_view"
+    rest_mock.head(
+        f"{TEST_URI}v1/namespaces/{namespace}/views/{view}",


Could we add a test case here for a multi-level namespace as well?

@sungwy thanks! Is that as simple as creating a test case with:

multilevel_namespace = "core.examples.some_namespace" view = "some_view" rest_mock.head( f"{TEST_URI}v1/namespaces/{multilevel_namespace}/views/{view}", status_code=404, request_headers=TEST_HEADERS, )

shiv-io · 2024-11-08T00:04:14Z

@sungwy thanks for reviewing! Let me know if there's anything else. I noticed we don't yet have docs for list_views (#817) and drop_views (#820), btw.

shiv-io · 2024-11-19T01:19:32Z

@sungwy just bumping this in case this fell off your radar!

sungwy · 2024-12-07T02:38:38Z

Hi @shiv-io !

Sorry this fell off my radar. Could we actually add an integration test here as well, now that we have a new REST Catalog image we are testing against that supports the view endpoints? :)

#1389

Fokko · 2025-01-15T15:30:20Z

@shiv-io Gentle ping :)

shiv-io · 2025-01-18T16:28:48Z

@sungwy I'm seeing that the /v1/namespaces/default/views endpoint doesn't return any views. How would I go about adding an integration test for view_exists given pyiceberg currently doesn't support create view? Appreciate any direction here in case I'm missing something

sungwy · 2025-01-18T19:20:16Z

Hi @shiv-io you make a great point!

I think we could still create an integration test by leveraging the fact that Iceberg is a language agnostic spec. We have a spark session fixture specified in our integration test suite that could be used to create a view, that could in turn be queries by PyIceberg.

Invoking an action using PyIceberg and then verifying the behavior using Spark is a common pattern in our integration test suite, and I think we could do the reverse to create the view using Spark and then verify its existence using PyIceberg function instead in this case.

shiv-io · 2025-01-19T18:43:51Z

Makes sense, @sungwy -- thanks! Added the integration test and it passed. Let me know if that looks good!

sungwy · 2025-01-22T02:20:18Z

This looks good to me @shiv-io ! Thank you very much for including the integration test to test the API :)

Could we run make lint to make the CI pass? Other than that, this looks good to be merged!

shiv-io · 2025-01-22T02:36:42Z

@sungwy thanks for the review :)

kevinjqliu

LGTM! Thanks for the contribution :)

sungwy

Lgtm as well. Thank you for putting together this PR @shiv-io 🙂

shivonchain added 5 commits October 20, 2024 15:41

Add view exists

9753152

lint

8712168

add return type annotations

719cd8e

Add method to InMemoryCatalog

e7eb718

Add tests

ee38a1c

shiv-io mentioned this pull request Oct 20, 2024

Add view support to the Rest Catalog #818

Open

7 tasks

shiv-io marked this pull request as ready for review October 20, 2024 20:26

sungwy reviewed Oct 30, 2024

View reviewed changes

shivonchain added 3 commits November 7, 2024 18:51

Add test for multilevel namespace

9310fc9

Lint

ea68f88

Docs

a0fd80a

Merge branch 'apache:main' into dev/add-view-exists

f8cde39

Merge branch 'main' into dev/add-view-exists

7586e87

Add integration test

c028042

lint

4672e15

kevinjqliu approved these changes Jan 22, 2025

View reviewed changes

sungwy approved these changes Jan 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `view_exists` method to REST Catalog #1242

Add `view_exists` method to REST Catalog #1242

shiv-io commented Oct 20, 2024 •

edited

Loading

shiv-io commented Oct 20, 2024

sungwy commented Oct 26, 2024

shiv-io commented Oct 26, 2024

sungwy left a comment

sungwy Oct 30, 2024

shiv-io Nov 7, 2024

shiv-io commented Nov 8, 2024

shiv-io commented Nov 19, 2024

sungwy commented Dec 7, 2024

Fokko commented Jan 15, 2025

shiv-io commented Jan 18, 2025 •

edited

Loading

sungwy commented Jan 18, 2025

shiv-io commented Jan 19, 2025 •

edited

Loading

sungwy commented Jan 22, 2025

shiv-io commented Jan 22, 2025

kevinjqliu left a comment

sungwy left a comment

Add view_exists method to REST Catalog #1242

Are you sure you want to change the base?

Add view_exists method to REST Catalog #1242

Conversation

shiv-io commented Oct 20, 2024 • edited Loading

shiv-io commented Oct 20, 2024

sungwy commented Oct 26, 2024

shiv-io commented Oct 26, 2024

sungwy left a comment

Choose a reason for hiding this comment

sungwy Oct 30, 2024

Choose a reason for hiding this comment

shiv-io Nov 7, 2024

Choose a reason for hiding this comment

shiv-io commented Nov 8, 2024

shiv-io commented Nov 19, 2024

sungwy commented Dec 7, 2024

Fokko commented Jan 15, 2025

shiv-io commented Jan 18, 2025 • edited Loading

sungwy commented Jan 18, 2025

shiv-io commented Jan 19, 2025 • edited Loading

sungwy commented Jan 22, 2025

shiv-io commented Jan 22, 2025

kevinjqliu left a comment

Choose a reason for hiding this comment

sungwy left a comment

Choose a reason for hiding this comment

Add `view_exists` method to REST Catalog #1242

Add `view_exists` method to REST Catalog #1242

shiv-io commented Oct 20, 2024 •

edited

Loading

shiv-io commented Jan 18, 2025 •

edited

Loading

shiv-io commented Jan 19, 2025 •

edited

Loading