Introduce hierarchical namespaces into SqlCatalog #591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing the Python implementation of SqlCatalog with the Java implementation (JdbcCatalog), I have noticed some differences that this PR tries to address. In my opinion, we should be able to read from the same catalog database, using both the Java or Python implementations with no impact.
Here is a list of changes proposed by this PR:
.
. For example,ns1.ns2.ns3
is a valid namespace in Java, but not with the current Python implementation. Identifiers will now have an optional catalog_name, zero or more namespaces and a table_name. For example, an identifier for tablecatalog_name.ns1.ns2.ns3.table_name
will be represented as the following tuple:("catalog_name", "ns1", "ns2", "ns3", "table_name")
create_table()
,register_table()
now supports a table identifier with an optional catalog name.list
CLI commandHere is a list of things to do before opening PR:
list
CLI command fix is good