-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlCatalog and other catalog works different on load_namespace_properties #769
Comments
@kevinjqliu Seems like behavior of SqlCatalog for load_namespace_properties is rectified in current version. I checked above code snippet, it raises I think we can close this issue and its parent issue #813 as well. |
@soumya-ghosh I think this test covers the issue reported iceberg-python/tests/catalog/test_sql.py Lines 1204 to 1213 in f05b1ae
Would you agree? |
Yes, that's correct. I don't see this test in 0.6.0 tag. |
Apache Iceberg version
0.6.0 (latest release)
Please describe the bug 🐞
During the development of a new feature I encountered a behaviour in the implementation of the SqlCatalog that currently we are using as test catalog and I think is a bug.
In the documentation of the abstract method list_namespace_properties there is a reference to an exception being thrown if the namespace does not exist, but the current implementation of SqlCatalog returns an empty dict when the namespace does not exist instead of raising the exception.
In this way the catalogs, although part of the same "interface" work and function in two completely different ways.
How to reproduce it
Expected behavior
As described in the abstract method documentation, the expected behavior is to raise a NoSucheNameSpaceError exception.
the same behavior indeed is also implemented in the GlueCatalog that we use on production code.
The text was updated successfully, but these errors were encountered: