Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement update for remove-snapshots action #1561

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Implement update for remove-snapshots action #1561

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b6ba319
Implement update for `remove-snapshot` action
grihabor Jan 22, 2025
88064c0
Add tests
grihabor Jan 22, 2025
818f771
Make sure parent_snapshot_id is consistent
grihabor Jan 22, 2025
9b31690
Set parent_snapshot_id to None
grihabor Jan 23, 2025
c5cbfe4
cherry-pick: Support Remove Branch or Tag APIs (#822)
grihabor Jan 23, 2025
29feaf7
Make sure refs are removed when removing snapshots
grihabor Jan 23, 2025
9e3f7c7
Fix ruff and pydocstyle
grihabor Jan 27, 2025
b9c912d
Remove statistics
grihabor Jan 30, 2025
d515e74
Fix name collision
grihabor Jan 30, 2025
c7481fe
Remove entries from snapshot log
grihabor Jan 30, 2025
da4db9f
Introduce constants for test readability
grihabor Feb 1, 2025
19e17f0
Allow to remove main branch
grihabor Feb 1, 2025
32e1e85
Revert changes (moved to #1598)
grihabor Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pyiceberg/table/update/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,16 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl
return base_metadata.model_copy(update=metadata_updates)


@_apply_table_update.register(RemoveSnapshotsUpdate)
def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context: _TableMetadataUpdateContext) -> TableMetadata:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the java reference

https://github.com/apache/iceberg/blob/be6e9daf8901cdee63197e77fcf95624bb694f39/core/src/main/java/org/apache/iceberg/TableMetadata.java#L1396-L1426

if not any(s.snapshot_id == update.snapshot_id for s in base_metadata.snapshots):
raise ValueError(f"Snapshot with snapshot id {update.snapshot_id} does not exist")

snapshots = [s for s in base_metadata.snapshots if s.snapshot_id != update.snapshot_id]
context.add_update(update)
return base_metadata.model_copy(update={"snapshots": snapshots})


@_apply_table_update.register(AddSortOrderUpdate)
def _(update: AddSortOrderUpdate, base_metadata: TableMetadata, context: _TableMetadataUpdateContext) -> TableMetadata:
context.add_update(update)
Expand Down