Implement update for remove-snapshots action
#1561
Conversation
grihabor
changed the title
remove-snapshot actionremove-snapshots action
There was a problem hiding this comment.
Thanks! This was one of the missing update functions mentioned in #952
Do you mind also including some tests? Similar to
iceberg-python/tests/table/test_init.py
Lines 663 to 682 in 2cd4e78
|
Sure! Thanks for the fast review |
| snapshot_ids=[3051729675574597004], | ||
| ) | ||
| new_metadata = update_table_metadata(table_v2.metadata, (update,)) | ||
| assert len(new_metadata.snapshots) == 1 |
There was a problem hiding this comment.
if theres 1 snapshot, isnt that the current snapshot. if so, wouldnt it error?
There was a problem hiding this comment.
This is what's left after the removal, originally fixture has 2 snapshots
| @@ -455,6 +455,19 @@ def _(update: SetSnapshotRefUpdate, base_metadata: TableMetadata, context: _Tabl | |||
| return base_metadata.model_copy(update=metadata_updates) | |||
|
|
|||
|
|
|||
| @_apply_table_update.register(RemoveSnapshotsUpdate) | |||
| def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context: _TableMetadataUpdateContext) -> TableMetadata: | |||
There was a problem hiding this comment.
| def _(update: RemoveSnapshotsUpdate, base_metadata: TableMetadata, context: _TableMetadataUpdateContext) -> TableMetadata: | ||
| for remove_snapshot_id in update.snapshot_ids: | ||
| if remove_snapshot_id == base_metadata.current_snapshot_id: | ||
| raise ValueError(f"Can't remove current snapshot id {remove_snapshot_id}") |
There was a problem hiding this comment.
should we block the current snapshot?
There was a problem hiding this comment.
I'm not an expert in iceberg spec, but it's not clear what should happen if you try to remove the current snapshot.
I'm also not sure if I should update parent_snapshot_id in every snapshot that was referencing removed snapshots
There was a problem hiding this comment.
Decided to set parent_snapshot_id to None if the parent is gone
|
Hey @kevinjqliu, ready for another review round. I had to cherry pick the changes from #822 to reuse the code that removes refs |
No description provided.