Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
sungwy authored Aug 26, 2024
1 parent 6a17d10 commit 51a61bb
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pyiceberg/table/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2499,8 +2499,6 @@ def update_column(
name=updated.name,
field_type=field_type or updated.field_type,
doc=doc if doc is not None else updated.doc,
# will raise ValidatorError
# if trying to change an identifier field from required to optional upon commit
required=updated.required,
)
else:
Expand All @@ -2509,8 +2507,6 @@ def update_column(
name=field.name,
field_type=field_type or field.field_type,
doc=doc if doc is not None else field.doc,
# will raise ValidatorError
# if trying to change an identifier field from required to optional upon commit
required=field.required,
)

Expand Down

0 comments on commit 51a61bb

Please sign in to comment.