Apply suggestions from code review

Co-authored-by: Sung Yun <[email protected]>
apache · Aug 24, 2024 · 6a17d10 · 6a17d10
1 parent 1ad7448
commit 6a17d10
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pyiceberg/table/__init__.py b/pyiceberg/table/__init__.py
@@ -2501,7 +2501,7 @@ def update_column(
                 doc=doc if doc is not None else updated.doc,
                 # will raise ValidatorError
                 # if trying to change an identifier field from required to optional upon commit
-                required=required or updated.required,
+                required=updated.required,
             )
         else:
             self._updates[field.field_id] = NestedField(
@@ -2511,7 +2511,7 @@ def update_column(
                 doc=doc if doc is not None else field.doc,
                 # will raise ValidatorError
                 # if trying to change an identifier field from required to optional upon commit
-                required=required or field.required,
+                required=field.required,
             )
 
         if required is not None: