Skip to content

infra: fix artifact name in verify_rc.sh #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinjqliu wants to merge 2 commits into from
Closed

infra: fix artifact name in verify_rc.sh #581

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aab527
fix verify_rc.sh
kevinjqliu Sep 28, 2025
f6bfe46
infra: fix rc internal folder name
zeroshade Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dev/release/verify_rc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ RC="$2"

ICEBERG_DIST_BASE_URL="https://downloads.apache.org/iceberg"
DOWNLOAD_RC_BASE_URL="https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-go-${VERSION}-rc${RC}"
ARCHIVE_BASE_NAME="apache-iceberg-go-${VERSION}-rc${RC}"
ARCHIVE_BASE_NAME="apache-iceberg-go-${VERSION}"
Copy link
Member

@zeroshade zeroshade Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we need to update the workflow verify test as this creates a bad directory name

SOURCE_DIR_NAME="apache-iceberg-go-${VERSION}-rc${RC}"

: "${VERIFY_DEFAULT:=1}"
: "${VERIFY_DOWNLOAD:=${VERIFY_DEFAULT}}"
Expand Down Expand Up @@ -193,7 +194,7 @@ import_gpg_keys
fetch_archive
ensure_source_directory
ensure_go
pushd "${ARCHIVE_BASE_NAME}"
pushd "${SOURCE_DIR_NAME}"
test_source_distribution
popd

Expand Down
Loading