infra: fix artifact name in verify_rc.sh #581
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
looks like the release pipeline is really fragile... we might have to dig deeper and fix the release_rc script |
Fokko
approved these changes
Oct 1, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Ran into the same issue, and this fixed it 👍
zeroshade
reviewed
Oct 1, 2025
dev/release/verify_rc.sh
Outdated
| ICEBERG_DIST_BASE_URL="https://downloads.apache.org/iceberg" | ||
| DOWNLOAD_RC_BASE_URL="https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-go-${VERSION}-rc${RC}" | ||
| ARCHIVE_BASE_NAME="apache-iceberg-go-${VERSION}-rc${RC}" | ||
| ARCHIVE_BASE_NAME="apache-iceberg-go-${VERSION}" |
Member
There was a problem hiding this comment.
looks like we need to update the workflow verify test as this creates a bad directory name
Member
|
@kevinjqliu @Fokko thoughts on the update I made to this PR to correct the internal folder name? |
Closed
Contributor
Author
|
closing in favor of #588 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tar file is named
apache-iceberg-go-0.4.0.tar.gzbut the folder inside is namedapache-iceberg-go-0.4.0-rc0This unblocks us from verifying an RC release.
We should follow up and fix the underlying issue by renaming the folder inside
apache-iceberg-go-0.4.0Testing
Tested with https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-go-0.4.0-rc0/