Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Translate "Table ID" Page for Flink CDC Chinese Documentation #3888

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[docs] Translate "Table ID" Page for Flink CDC Chinese Documentation #3888

wants to merge 4 commits into from

Conversation

Kevin-Caesar
Copy link

Translate "Table ID" Page for Flink CDC Chinese Documentation

@github-actions github-actions bot added the docs Improvements or additions to documentation label Jan 23, 2025
@ChaomingZhangCN
Copy link
Contributor

@Kevin-Caesar Nice job! There are some other pages that need to be translated into Chinese. Would you like to help with that?

@Kevin-Caesar
Copy link
Author

@ChaomingZhangCN Ok, I will try.

@Kevin-Caesar Nice job! There are some other pages that need to be translated into Chinese. Would you like to help with that?

gtk96
gtk96 reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@gtk96 gtk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kevin-Caesar Thank you for the excellent work. I have a reference for a Chinese typesetting guide here. Would you mind optimizing this pull request according to this style?https://github.com/sparanoid/chinese-copywriting-guidelines

@Kevin-Caesar
Copy link
Author

@Kevin-Caesar Thank you for the excellent work. I have a reference for a Chinese typesetting guide here. Would you mind optimizing this pull request according to this style?https://github.com/sparanoid/chinese-copywriting-guidelines

Sorry for my bad style, I have optimized this.

@Kevin-Caesar Kevin-Caesar requested a review from gtk96 February 8, 2025 05:43
@gtk96
Copy link
Contributor

gtk96 commented Feb 8, 2025

@Kevin-Caesar Thank you for the excellent work. I have a reference for a Chinese typesetting guide here. Would you mind optimizing this pull request according to this style?https://github.com/sparanoid/chinese-copywriting-guidelines

Sorry for my bad style, I have optimized this.

This change looks great to me, A small suggestion: Could you sync this update to the English documentation as well? Let's keep the documentation consistent. cc @ChaomingZhangCN @leonardBang

ChaomingZhangCN
ChaomingZhangCN approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@ChaomingZhangCN ChaomingZhangCN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtk96 gtk96 gtk96 approved these changes

@ChaomingZhangCN ChaomingZhangCN ChaomingZhangCN approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
docs Improvements or additions to documentation reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kevin-Caesar @ChaomingZhangCN @gtk96