Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #57215

…ving it to the memory pool for guaranteed release (#57215)

when aggregate, the `cur_row` is useless, so we should call
`_clear_row_agg` to release it, rather than leaving it to the memory
pool for guaranteed release
@github-actions github-actions bot requested a review from morrySnow as a code owner October 24, 2025 07:05
@Thearas
Copy link
Contributor

Thearas commented Oct 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 24, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32814 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c4bff9b9d588df4487d2ec0452afb85f0dba994, data reload: false

------ Round 1 ----------------------------------
q1	17607	5518	5422	5422
q2	2031	409	315	315
q3	12422	1288	737	737
q4	10554	891	487	487
q5	9619	2391	2127	2127
q6	195	164	135	135
q7	903	743	607	607
q8	9340	1436	1161	1161
q9	5387	5010	4912	4912
q10	6757	2291	1802	1802
q11	477	275	252	252
q12	333	352	211	211
q13	17791	3582	3004	3004
q14	231	220	228	220
q15	520	461	463	461
q16	448	432	364	364
q17	593	867	383	383
q18	6684	6524	6520	6520
q19	1089	942	526	526
q20	323	342	206	206
q21	2787	2143	1952	1952
q22	1056	1031	1010	1010
Total cold run time: 107147 ms
Total hot run time: 32814 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5508	5475	5471	5471
q2	233	334	230	230
q3	2243	2610	2303	2303
q4	1378	1767	1338	1338
q5	4399	5058	4998	4998
q6	172	163	130	130
q7	2069	1962	1795	1795
q8	2609	2867	2668	2668
q9	7384	7253	7172	7172
q10	3084	3189	2742	2742
q11	574	515	491	491
q12	675	798	630	630
q13	3341	3758	3147	3147
q14	266	302	270	270
q15	523	468	464	464
q16	444	483	446	446
q17	1224	1719	1233	1233
q18	7628	7580	7389	7389
q19	821	1119	1112	1112
q20	1996	2044	1903	1903
q21	5366	4880	4508	4508
q22	1060	1088	1052	1052
Total cold run time: 52997 ms
Total hot run time: 51492 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192251 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c4bff9b9d588df4487d2ec0452afb85f0dba994, data reload: false

query1	943	394	411	394
query2	6215	2005	1897	1897
query3	8692	198	190	190
query4	33607	23748	23462	23462
query5	3560	581	449	449
query6	292	184	179	179
query7	4213	485	303	303
query8	296	242	235	235
query9	9543	2629	2617	2617
query10	467	325	251	251
query11	18036	15367	15216	15216
query12	158	109	109	109
query13	1545	564	418	418
query14	9524	6891	6552	6552
query15	233	194	178	178
query16	8041	615	502	502
query17	1509	774	623	623
query18	2162	430	332	332
query19	235	193	178	178
query20	121	130	131	130
query21	206	129	109	109
query22	4733	4822	4618	4618
query23	35797	34013	34419	34013
query24	7699	2705	2726	2705
query25	503	477	428	428
query26	1027	260	169	169
query27	2110	490	366	366
query28	5373	2248	2259	2248
query29	613	572	460	460
query30	236	193	162	162
query31	1054	923	825	825
query32	94	68	68	68
query33	541	388	315	315
query34	751	865	535	535
query35	814	801	740	740
query36	1003	1058	955	955
query37	102	88	65	65
query38	3925	4025	3920	3920
query39	1547	1495	1489	1489
query40	207	121	114	114
query41	49	46	45	45
query42	118	100	101	100
query43	511	541	491	491
query44	1405	857	829	829
query45	183	190	173	173
query46	904	1058	683	683
query47	2004	1970	1949	1949
query48	433	438	353	353
query49	782	493	417	417
query50	699	681	425	425
query51	7319	7407	7263	7263
query52	104	104	94	94
query53	231	260	189	189
query54	555	561	491	491
query55	81	77	81	77
query56	268	271	261	261
query57	1264	1293	1206	1206
query58	240	218	221	218
query59	3184	3233	3090	3090
query60	293	286	264	264
query61	110	112	113	112
query62	794	758	711	711
query63	239	201	190	190
query64	4505	1007	646	646
query65	3357	3309	3306	3306
query66	1008	426	314	314
query67	16550	15866	15757	15757
query68	7565	825	544	544
query69	478	304	266	266
query70	1237	1158	1088	1088
query71	420	300	264	264
query72	5093	3741	3900	3741
query73	638	746	350	350
query74	10339	9136	9051	9051
query75	3519	3177	2676	2676
query76	3570	1197	758	758
query77	765	379	278	278
query78	10500	10506	9638	9638
query79	3721	899	594	594
query80	731	527	426	426
query81	497	262	220	220
query82	652	114	93	93
query83	177	156	145	145
query84	276	97	83	83
query85	780	375	289	289
query86	339	319	301	301
query87	4338	4373	4212	4212
query88	4438	2406	2401	2401
query89	407	325	299	299
query90	1865	190	190	190
query91	131	140	109	109
query92	64	54	51	51
query93	1931	880	557	557
query94	648	406	307	307
query95	348	274	276	274
query96	489	604	285	285
query97	3160	3237	3108	3108
query98	232	201	203	201
query99	1550	1419	1279	1279
Total cold run time: 295815 ms
Total hot run time: 192251 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.32 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c4bff9b9d588df4487d2ec0452afb85f0dba994, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.11
query5	0.53	0.52	0.51
query6	1.14	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.55	0.49	0.50
query10	0.55	0.55	0.54
query11	0.13	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.62	0.60
query14	0.79	0.82	0.79
query15	0.84	0.82	0.86
query16	0.41	0.41	0.37
query17	1.07	1.05	1.00
query18	0.24	0.22	0.23
query19	1.84	1.90	1.90
query20	0.01	0.01	0.01
query21	15.40	0.90	0.57
query22	0.73	0.73	0.66
query23	15.14	1.45	0.57
query24	3.18	1.38	1.45
query25	0.18	0.06	0.14
query26	0.32	0.15	0.13
query27	0.05	0.06	0.04
query28	13.80	0.99	0.44
query29	12.57	3.83	3.24
query30	0.26	0.09	0.08
query31	2.82	0.59	0.37
query32	3.22	0.53	0.46
query33	2.96	3.00	3.06
query34	16.60	5.24	4.52
query35	4.59	4.56	4.58
query36	0.64	0.50	0.48
query37	0.08	0.05	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.18	0.14	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.04
Total cold run time: 103.8 s
Total hot run time: 29.32 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants