Skip to content

[compile](arm) fix arm compile failed #55798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

[compile](arm) fix arm compile failed #55798

merged 1 commit into from
Sep 9, 2025

Conversation

@HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Sep 9, 2025

Fix arm compile failed：

FAILED: src/vec/CMakeFiles/Vec.dir/functions/array/function_array_distance.cpp.o
ccache /usr/local/bin/ldb-toolchain/bin/clang++ -DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG -DBOOST_STACKTRACE_USE_BACKTRACE -DBOOST_SYSTEM_NO_DEPRECATED -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX=1 -DBRPC_ENABLE_CPU_PROFILER -DGLOG_CUSTOM_PREFIX_SUPPORT -DHAVE_INTTYPES_H -DHAVE_NETINET_IN_H -DLIBJVM -DS2_USE_GFLAGS -DS2_USE_GLOG -DUSE_DORIS_HADOOP_HDFS -DUSE_HADOOP_HDFS -DUSE_JEMALLOC -DUSE_MEM_TRACKER -D__STDC_FORMAT_MACROS -I/home/zcp/repo_center/doris_branch-3.1/doris/be/src/apache-orc/c++/include -I/home/zcp/repo_center/doris_branch-3.1/doris/be/build_RELEASE/src/apache-orc/c++/include -I/home/zcp/repo_center/doris_branch-3.1/doris/be/build_RELEASE/src/clucene/src/shared -I/home/zcp/repo_center/doris_branch-3.1/doris/be/src/clucene/src/core -I/home/zcp/repo_center/doris_branch-3.1/doris/be/src/clucene/src/shared -I/home/zcp/repo_center/doris_branch-3.1/doris/be/src/clucene/src/contribs-lib -I/home/zcp/repo_center/doris_branch-3.1/doris/be/src -I/home/zcp/repo_center/doris_branch-3.1/doris/be/test -I/usr/local/bisheng-jdk-17/include -I/usr/local/bisheng-jdk-17/include/linux -isystem /home/zcp/repo_center/doris_branch-3.1/doris/be/../common -isystem /home/zcp/repo_center/doris_branch-3.1/doris/be/../gensrc/build -isystem /home/zcp/repo_center/doris_branch-3.1/doris/thirdparty/installed/include -isystem /home/zcp/repo_center/doris_branch-3.1/doris/thirdparty/installed/gperftools/include -DENABLE_CACHE_LOCK_DEBUG -O3 -DNDEBUG  -O3 -DNDEBUG   -D OS_LINUX -g -Wall -Wextra -Werror -pthread -fstrict-aliasing -fno-omit-frame-pointer -Wnon-virtual-dtor -Wno-unused-parameter -Wno-sign-compare -fcolor-diagnostics -Wpedantic -Wshadow-field -Wunused -Wunused-command-line-argument -Wunused-exception-parameter -Wunused-volatile-lvalue -Wunused-template -Wunused-member-function -Wunused-macros -Wconversion -Wno-gnu-statement-expression -Wno-implicit-float-conversion -Wno-implicit-int-conversion -Wno-sign-conversion -Wno-missing-field-initializers -Wno-unused-const-variable -Wno-shorten-64-to-32 -march=armv8-a+crc -std=gnu++20 -MD -MT src/vec/CMakeFiles/Vec.dir/functions/array/function_array_distance.cpp.o -MF src/vec/CMakeFiles/Vec.dir/functions/array/function_array_distance.cpp.o.d -o src/vec/CMakeFiles/Vec.dir/functions/array/function_array_distance.cpp.o -c /home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/functions/array/function_array_distance.cpp
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/functions/array/function_array_distance.cpp:38:1: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
PRAGMA_IMPRECISE_FUNCTION_BEGIN
^
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/functions/array/function_array_distance.cpp:30:5: note: expanded from macro 'PRAGMA_IMPRECISE_FUNCTION_BEGIN'
    _Pragma("GCC push_options")         \
    ^
<scratch space>:133:6: note: expanded from here
 GCC push_options
     ^
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/functions/array/function_array_distance.cpp:38:1: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/functions/array/function_array_distance.cpp:31:13: note: expanded from macro 'PRAGMA_IMPRECISE_FUNCTION_BEGIN'
            _Pragma("GCC optimize (\"unroll-loops,associative-math,no-signed-zeros\")")
            ^
<scratch space>:135:6: note: expanded from here
 GCC optimize ("unroll-loops,associative-math,no-signed-zeros")
     ^
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/functions/array/function_array_distance.cpp:81:1: error: unknown pragma ignored [-Werror,-Wunknown-pragmas]
PRAGMA_IMPRECISE_FUNCTION_END
^
/home/zcp/repo_center/doris_branch-3.1/doris/be/src/vec/functions/array/function_array_distance.cpp:32:39: note: expanded from macro 'PRAGMA_IMPRECISE_FUNCTION_END'
#define PRAGMA_IMPRECISE_FUNCTION_END _Pragma("GCC pop_options")
                                      ^
<scratch space>:137:6: note: expanded from here
 GCC pop_options
     ^

@HappenLee HappenLee requested a review from morrySnow as a code owner September 9, 2025 04:12
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@HappenLee
Copy link
Contributor Author

HappenLee commented Sep 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 9, 2025

TPC-H: Total hot run time: 32612 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 32bfb90c9d8038bb6db01cebdeafecd36932d219, data reload: false

------ Round 1 ----------------------------------
q1	17742	5459	5391	5391
q2	2015	387	287	287
q3	12183	1242	755	755
q4	10541	872	451	451
q5	9523	2366	2091	2091
q6	187	164	136	136
q7	888	751	626	626
q8	9334	1435	1191	1191
q9	5238	4917	4871	4871
q10	6751	2265	1837	1837
q11	494	275	274	274
q12	331	352	207	207
q13	17763	3575	3004	3004
q14	227	234	205	205
q15	531	478	457	457
q16	442	433	367	367
q17	617	858	374	374
q18	6749	6394	6406	6394
q19	1216	937	537	537
q20	326	348	220	220
q21	2810	2125	1960	1960
q22	1026	1007	977	977
Total cold run time: 106934 ms
Total hot run time: 32612 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5521	5487	5474	5474
q2	237	331	237	237
q3	2238	2625	2329	2329
q4	1386	1776	1350	1350
q5	4383	4980	4984	4980
q6	168	162	127	127
q7	2071	1964	1835	1835
q8	2584	2843	2710	2710
q9	7288	7248	7135	7135
q10	3034	3243	2721	2721
q11	583	526	509	509
q12	702	744	618	618
q13	3409	3797	3169	3169
q14	301	306	271	271
q15	535	460	476	460
q16	436	479	462	462
q17	1208	1742	1272	1272
q18	7549	7425	7230	7230
q19	789	1080	1118	1080
q20	1999	2082	1886	1886
q21	5369	4938	4410	4410
q22	1090	1044	1003	1003
Total cold run time: 52880 ms
Total hot run time: 51268 ms

@doris-robot
Copy link

doris-robot commented Sep 9, 2025

TPC-DS: Total hot run time: 192090 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 32bfb90c9d8038bb6db01cebdeafecd36932d219, data reload: false

query1	978	411	400	400
query2	6323	1881	1876	1876
query3	8690	196	199	196
query4	33511	23624	23513	23513
query5	3708	603	444	444
query6	288	200	172	172
query7	4197	485	314	314
query8	303	239	225	225
query9	9464	2634	2604	2604
query10	469	321	256	256
query11	18237	15725	15269	15269
query12	169	106	108	106
query13	1558	536	427	427
query14	10680	7079	7167	7079
query15	248	195	177	177
query16	8020	698	504	504
query17	1568	781	608	608
query18	2171	429	340	340
query19	234	192	184	184
query20	127	125	116	116
query21	209	137	106	106
query22	4700	4713	4315	4315
query23	35198	34176	33845	33845
query24	7307	2688	2657	2657
query25	538	494	435	435
query26	802	292	173	173
query27	2060	490	375	375
query28	5392	2226	2194	2194
query29	723	593	466	466
query30	241	194	163	163
query31	990	939	844	844
query32	101	62	61	61
query33	522	379	317	317
query34	802	876	534	534
query35	812	801	726	726
query36	998	1063	956	956
query37	105	92	70	70
query38	4092	4063	3962	3962
query39	1536	1475	1484	1475
query40	200	116	108	108
query41	52	53	45	45
query42	120	106	106	106
query43	517	522	478	478
query44	1333	810	824	810
query45	184	174	177	174
query46	881	1070	679	679
query47	2016	2013	1937	1937
query48	417	428	352	352
query49	726	492	401	401
query50	667	699	421	421
query51	7297	7344	7271	7271
query52	99	104	93	93
query53	229	271	196	196
query54	558	560	465	465
query55	78	73	81	73
query56	281	265	265	265
query57	1268	1305	1203	1203
query58	237	218	216	216
query59	3039	3167	3158	3158
query60	289	286	265	265
query61	119	112	119	112
query62	784	752	706	706
query63	234	190	190	190
query64	3825	1017	657	657
query65	3517	3322	3296	3296
query66	1048	413	304	304
query67	16505	15847	15653	15653
query68	7822	817	534	534
query69	493	308	269	269
query70	1169	1157	1126	1126
query71	390	289	257	257
query72	5812	3729	3796	3729
query73	635	733	346	346
query74	10167	9322	8953	8953
query75	3255	3099	2672	2672
query76	3156	1173	757	757
query77	578	363	272	272
query78	10448	10388	9537	9537
query79	3584	832	585	585
query80	643	517	434	434
query81	504	263	222	222
query82	570	118	87	87
query83	154	162	144	144
query84	244	103	82	82
query85	774	358	301	301
query86	387	294	302	294
query87	4307	4352	4223	4223
query88	5090	2390	2374	2374
query89	403	331	285	285
query90	1774	188	184	184
query91	134	136	110	110
query92	62	56	54	54
query93	2111	861	540	540
query94	676	416	317	317
query95	344	275	267	267
query96	500	608	282	282
query97	3187	3285	3206	3206
query98	217	207	205	205
query99	1546	1392	1324	1324
Total cold run time: 295727 ms
Total hot run time: 192090 ms

@doris-robot
Copy link

doris-robot commented Sep 9, 2025

ClickBench: Total hot run time: 28.89 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 32bfb90c9d8038bb6db01cebdeafecd36932d219, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.11	0.10
query5	0.52	0.49	0.50
query6	1.12	0.73	0.74
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.60	0.50	0.49
query10	0.56	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.63	0.61	0.58
query14	0.78	0.81	0.79
query15	0.85	0.83	0.82
query16	0.40	0.38	0.40
query17	1.07	1.06	1.07
query18	0.24	0.22	0.23
query19	1.98	1.86	1.83
query20	0.02	0.01	0.02
query21	15.37	0.95	0.57
query22	0.72	0.74	0.59
query23	15.21	1.39	0.52
query24	3.20	1.19	0.97
query25	0.21	0.21	0.07
query26	0.24	0.13	0.14
query27	0.05	0.06	0.05
query28	13.72	1.01	0.43
query29	12.59	3.95	3.29
query30	0.25	0.09	0.06
query31	2.82	0.60	0.39
query32	3.22	0.54	0.47
query33	3.00	3.02	3.07
query34	16.88	5.16	4.55
query35	4.58	4.58	4.53
query36	0.64	0.50	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.29 s
Total hot run time: 28.89 s

@doris-robot
Copy link

doris-robot commented Sep 9, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.55% (12758/28010)
Line Coverage 36.37% (113726/312690)
Region Coverage 34.01% (65056/191311)
Branch Coverage 31.03% (34140/110012)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 9, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.47% (21067/27549)
Line Coverage 69.81% (217616/311716)
Region Coverage 67.77% (130169/192088)
Branch Coverage 61.31% (67759/110526)

dataroaring
dataroaring approved these changes Sep 9, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 04525f6 into apache:branch-3.1 Sep 9, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

dev/3.1.1-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HappenLee @hello-stephen @doris-robot @dataroaring @morrySnow