-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Feat: Make current_date aware of execution timezone. #18034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+106
−10
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
79c3254
Feat: Make current_date aware of execution timezone.
codetyri0n 42c5596
CI Fixes: Rectify assertion error of slt and update scalar_functions.md
codetyri0n 4376da5
CI Fixes: Comment out flaky test involving now().
codetyri0n 77bb4bc
CI Fixes: Resolve slt error.
codetyri0n cc8e5c5
Feat: Add helper function to calculate current_date and fix tests.
codetyri0n 5010f46
Chore: Refactor timezone conversion logic.
codetyri0n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
datafusion/sqllogictest/test_files/current_date_timezone.slt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
|
|
||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| ########## | ||
| ## current_date with timezone tests | ||
| ########## | ||
|
|
||
| # Test 1: Verify current_date is consistent within the same query (default UTC) | ||
| query B | ||
| SELECT current_date() = current_date(); | ||
| ---- | ||
| true | ||
|
|
||
| # Test 2: Verify alias 'today' works the same as current_date | ||
| query B | ||
| SELECT current_date() = today(); | ||
| ---- | ||
| true | ||
|
|
||
| # Test 3: Set timezone to +19:00 and verify current_date is still stable | ||
| statement ok | ||
| SET datafusion.execution.time_zone = '+19:00'; | ||
|
|
||
| query B | ||
| SELECT current_date() = current_date(); | ||
| ---- | ||
| true | ||
|
|
||
| #Test 4: Verify current_date matches cast(now() as date) in the same timezone | ||
codetyri0n marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| query B | ||
| SELECT current_date() = cast(now() as date); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For some reason, this test appears to be failing on main: |
||
| ---- | ||
| false | ||
|
|
||
| # Test 5: Test with negative offset timezone | ||
| statement ok | ||
| SET datafusion.execution.time_zone = '-08:00'; | ||
|
|
||
| query B | ||
| SELECT current_date() = today(); | ||
| ---- | ||
| true | ||
|
|
||
| # Test 6: Test with named timezone (America/New_York) | ||
| statement ok | ||
| SET datafusion.execution.time_zone = 'America/New_York'; | ||
|
|
||
| query B | ||
| SELECT current_date() = current_date(); | ||
| ---- | ||
| true | ||
|
|
||
| # Test 7: Verify date type is preserved | ||
| query T | ||
| SELECT arrow_typeof(current_date()); | ||
| ---- | ||
| Date32 | ||
|
|
||
| # Test 8: Reset to UTC | ||
| statement ok | ||
| SET datafusion.execution.time_zone = '+00:00'; | ||
|
|
||
| query B | ||
| SELECT current_date() = today(); | ||
| ---- | ||
| true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can rewrite this into something more idiomatic