Feat: Make current_date aware of execution timezone. #18034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
github-actions
bot
added
the
documentation
comphead
reviewed
Oct 13, 2025
comphead
reviewed
Oct 13, 2025
comphead
reviewed
Oct 13, 2025
| ); | ||
|
|
||
| // Get timezone from config and convert to local time | ||
| let days = if let Some(config) = info.execution_props().config_options() { |
There was a problem hiding this comment.
I think we can rewrite this into something more idiomatic
let days = info
.execution_props()
.config_options()
.and_then(|config| config.execution.time_zone.parse::<Tz>().ok())
.map_or_else(
|| datetime_to_days(&now_ts),
|tz| {
let local_now = tz.from_utc_datetime(&now_ts.naive_utc());
datetime_to_days(&local_now)
},
);
comphead
approved these changes
Oct 14, 2025
alamb
reviewed
Oct 14, 2025
|
|
||
| #Test 4: Verify current_date matches cast(now() as date) in the same timezone | ||
| query B | ||
| SELECT current_date() = cast(now() as date); |
There was a problem hiding this comment.
For some reason, this test appears to be failing on main:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?