Skip to content

Fix verification script and extended tests due to rustup changes #14990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 4, 2025
Merged

Fix verification script and extended tests due to rustup changes #14990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e1ca4b7
Fix rustup toolchain errors
alamb Mar 3, 2025
18e6dde
Use standard builder setup in extended tests
alamb Mar 3, 2025
438b582
fix yaml
alamb Mar 3, 2025
0ed0e0a
sprinkle sudo
alamb Mar 3, 2025
166cad9
Revert "sprinkle sudo"
alamb Mar 3, 2025
a20cd82
no contianer
alamb Mar 3, 2025
6a390ba
use rust container
alamb Mar 3, 2025
eea398c
fix extended jobs
alamb Mar 3, 2025
509adcd
fix
alamb Mar 3, 2025
96b63db
Update .github/workflows/extended.yml
alamb Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/extended.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
linux-build-lib:
name: linux build test
runs-on: ubuntu-latest
# note: do not use amd/rust container to preserve disk space
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -45,7 +46,7 @@ jobs:
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
source $HOME/.cargo/env
rustup default stable
rustup toolchain install
- name: Install Protobuf Compiler
run: sudo apt-get install -y protobuf-compiler
- name: Prepare cargo build
Expand All @@ -58,6 +59,7 @@ jobs:
name: cargo test 'extended_tests' (amd64)
needs: linux-build-lib
runs-on: ubuntu-latest
# note: do not use amd/rust container to preserve disk space
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -69,7 +71,7 @@ jobs:
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
source $HOME/.cargo/env
rustup default stable
rustup toolchain install
- name: Install Protobuf Compiler
run: sudo apt-get install -y protobuf-compiler
# For debugging, test binaries can be large.
Expand Down
5 changes: 4 additions & 1 deletion dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,11 @@ test_source_distribution() {

# build and test rust

# install the needed version of rust defined in rust-toolchain.toml
rustup toolchain install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the recommended fix from rustup


# raises on any formatting errors
rustup component add rustfmt --toolchain stable
rustup component add rustfmt
cargo fmt --all -- --check

# Clone testing repositories into the expected location
Expand Down