Fix verification script and extended tests due to rustup changes
#14990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
alamb
changed the title
rustup changes
alamb
commented
Mar 3, 2025
alamb
commented
Mar 3, 2025
| @@ -117,8 +117,11 @@ test_source_distribution() { | |||
|
|
|||
| # build and test rust | |||
|
|
|||
| # install the needed version of rust defined in rust-toolchain.toml | |||
| rustup toolchain install | |||
There was a problem hiding this comment.
This is the recommended fix from rustup
This reverts commit 0ed0e0a.
alamb
commented
Mar 3, 2025
.github/workflows/extended.yml
Outdated
|
|
||
| jobs: | ||
| # Check crate compiles and base cargo check passes | ||
| linux-build-lib: | ||
| name: linux build test | ||
| runs-on: ubuntu-latest | ||
| container: |
There was a problem hiding this comment.
this makes this job consistent with all the other CI jobs that use the rust container
alamb
commented
Mar 3, 2025
|
I think this PR now has the right fix. Next steps are:
I'll try and check later tonight but I have to run for a family event |
|
Here is an example CI run of the extended tests running cleanly: |
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
rustuppreviously would automatically install the toolchain (version of rust) thatwas needed if it wasn't already installed.
However, the recently released rustup version changes this behavior
https://github.com/rust-lang/rustup/blob/f00c3d1fbcbe8d3ae2411e63ca906bc9b69e43d1/CHANGELOG.md?plain=1#L9-L17
Thus to ensure we have the correct toolchain installed, we need to run
rustup toolchain installWhat changes are included in this PR?
rustup toolchain installper release notesAre these changes tested?
Are there any user-facing changes?