Skip to content

[Variant] impl PartialEq and FromIterator<Option<..>> for VariantArray #8627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2025
Merged

[Variant] impl PartialEq and FromIterator<Option<..>> for VariantArray #8627

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea264c4
Remove ceremony from iterator of variants into VariantArray
friendlymatthew Oct 15, 2025
39d9eaa
Impl PartialEq for VariantArray
friendlymatthew Oct 15, 2025
271a29d
Merge branch 'main' into friendlymatthew/impl-partial-eq-variant-array
friendlymatthew Oct 16, 2025
13ca9fd
Nits
friendlymatthew Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions parquet-variant-compute/src/variant_array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ impl ExtensionType for VariantType {
/// assert_eq!(variant_array.value(0), Variant::from("such wow"));
/// ```
///
#[derive(Clone, Debug)]
#[derive(Debug, Clone, PartialEq)]
pub struct VariantArray {
/// Reference to the underlying StructArray
inner: StructArray,
Expand Down Expand Up @@ -741,7 +741,7 @@ impl From<ShreddedVariantFieldArray> for StructArray {
/// (partial shredding).
///
/// [Parquet Variant Shredding Spec]: https://github.com/apache/parquet-format/blob/master/VariantShredding.md#value-shredding
#[derive(Clone, Debug)]
#[derive(Debug, Clone, PartialEq)]
pub struct ShreddingState {
value: Option<BinaryViewArray>,
typed_value: Option<ArrayRef>,
Expand Down Expand Up @@ -1467,4 +1467,27 @@ mod test {
Variant::ShortString(ShortString::try_new("norm").unwrap())
);
}

#[test]
fn test_variant_equality() {
let v_iter = [None, Some(Variant::BooleanFalse), Some(Variant::Null), None];
let v = VariantArray::from_iter(v_iter.clone());

{
let v_copy = v.clone();
assert_eq!(v, v_copy);
}

{
let v_iter_reversed = v_iter.iter().cloned().rev();
let v_reversed = VariantArray::from_iter(v_iter_reversed);

assert_ne!(v, v_reversed);
}

{
let v_sliced = v.slice(0, 1);
assert_ne!(v, v_sliced);
}
}
}
Loading