[Variant] impl PartialEq and FromIterator<Option<..>> for VariantArray
#8627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @scovich This is unrelated, but I wonder if we should revisit the topic of equality? Especially how it mixes with Equivalence classes? 🤔 In my experimental repo, I had the Basically, Variant::Int8(n) => EquivalenceClass::ExactNumeric(n as i64),
Variant::Int16(n) => EquivalenceClass::ExactNumeric(n as i64),This way, we can test for equality across |
scovich
reviewed
Oct 15, 2025
|
cc @alamb |
alamb
changed the title
PartialEq for VariantArrayPartialEq and FromIterator<Option<..>> for VariantArray
alamb
approved these changes
Oct 16, 2025
samueleresca
pushed a commit
to samueleresca/arrow-rs
that referenced
this pull request
Oct 18, 2025
…tArray` (apache#8627) # Which issue does this PR close? - Closes apache#8610 # Rationale for this change Since the fields of `VariantArray` impl `PartialEq`, this PR simply derives `PartialEq` for `VariantArray` out. Based off of apache#8625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PartialEqforVariantArray#8610Rationale for this change
Since the fields of
VariantArrayimplPartialEq, this PR simply derivesPartialEqforVariantArrayout.
Based off of #8625