Make a good deal of @solana/rpc-transformers private#353
Merged
steveluscher merged 3 commits intomainfrom Apr 14, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 5964839 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
steveluscher
commented
Apr 5, 2025
Comment on lines
+1
to
+10
| export function downcastNodeToNumberIfBigint(value: bigint): number; | ||
| export function downcastNodeToNumberIfBigint<T>(value: T): T; | ||
| export function downcastNodeToNumberIfBigint(value: unknown): unknown { | ||
| return typeof value === 'bigint' | ||
| ? // FIXME(solana-labs/solana/issues/30341) Create a data type to represent u64 in the Solana | ||
| // JSON RPC implementation so that we can throw away this entire patcher instead of unsafely | ||
| // downcasting `bigints` to `numbers`. | ||
| Number(value) | ||
| : value; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
[Re: lines +1 to +11]
@lorisleiva, do we still have this because the Rust server doesn't know how to parse JSON with numbers in excess of Number.MAX_SAFE_INTEGER, or did we not ever test that? I can't remember.
See this comment inline on Graphite.
Member
There was a problem hiding this comment.
I don't remember either to be totally honest with you. My hunch is that we did not test this and we just kept the old logic in when refactoring the RPC packages.
BundleMonFiles updated (6)
Unchanged files (121)
Total files change +349B +0.1% Final result: ✅ View report in BundleMon website ➡️ |
steveluscher
force-pushed
the
04-05-make_a_good_deal_of_solana_rpc-transformers_private
branch
from
0ca4141 to
c99e002
Compare
steveluscher
force-pushed
the
04-04-document_solana_rpc-subscriptions-spec_with_typedoc
branch
from
23d6ef0 to
1d12a42
Compare
steveluscher
force-pushed
the
04-04-document_solana_rpc-subscriptions-spec_with_typedoc
branch
from
1d12a42 to
2c1779c
Compare
steveluscher
force-pushed
the
04-05-make_a_good_deal_of_solana_rpc-transformers_private
branch
from
c99e002 to
889a4c0
Compare
steveluscher
force-pushed
the
04-05-make_a_good_deal_of_solana_rpc-transformers_private
branch
from
889a4c0 to
c1ddaae
Compare
steveluscher
force-pushed
the
04-04-document_solana_rpc-subscriptions-spec_with_typedoc
branch
from
2c1779c to
2ea177a
Compare
steveluscher
force-pushed
the
04-04-document_solana_rpc-subscriptions-spec_with_typedoc
branch
from
2ea177a to
64d702a
Compare
steveluscher
force-pushed
the
04-05-make_a_good_deal_of_solana_rpc-transformers_private
branch
from
c1ddaae to
5afe503
Compare
This was referenced Apr 10, 2025
lorisleiva
reviewed
Apr 11, 2025
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Makes sense to me. Do we want to add a changeset for this since this is technically a breaking change? Maybe a minor bump is good enough since this is likely not used anyway?
steveluscher
changed the base branch from
graphite-base/353
to
04-10-repair_the_stakehistory_sysvar_fetcher
steveluscher
force-pushed
the
04-10-repair_the_stakehistory_sysvar_fetcher
branch
from
938dd25 to
5749656
Compare
steveluscher
force-pushed
the
04-05-make_a_good_deal_of_solana_rpc-transformers_private
branch
from
6444dd1 to
12953cd
Compare
Base automatically changed from
04-10-repair_the_stakehistory_sysvar_fetcher
to
graphite-base/375
April 11, 2025 17:45
steveluscher
force-pushed
the
04-05-make_a_good_deal_of_solana_rpc-transformers_private
branch
from
12953cd to
794395a
Compare
steveluscher
force-pushed
the
graphite-base/375
branch
from
dc6ffa8 to
2fb1fbc
Compare
steveluscher
force-pushed
the
04-05-make_a_good_deal_of_solana_rpc-transformers_private
branch
from
794395a to
73e796f
Compare
steveluscher
force-pushed
the
04-05-make_a_good_deal_of_solana_rpc-transformers_private
branch
from
73e796f to
5964839
Compare
steveluscher
changed the base branch from
graphite-base/353
to
repair_the_stakehistory_sysvar_fetcher-redo
This was referenced Apr 11, 2025
Base automatically changed from
repair_the_stakehistory_sysvar_fetcher-redo
to
main
April 11, 2025 18:01
steveluscher
deleted the
04-05-make_a_good_deal_of_solana_rpc-transformers_private
branch
Merged
This was referenced Apr 14, 2025
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I'm not sure that all of this machinery needs to be part of the public API. Please do correct me if I'm wrong.
Summary of Changes
Made methods internal.