-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document @solana/rpc-subscriptions-spec
with TypeDoc
#352
Document @solana/rpc-subscriptions-spec
with TypeDoc
#352
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -52,7 +52,7 @@ type PendingRpcRequestReturnTypeMapper<TMethodImplementation> = | |||
: never; | |||
|
|||
/** | |||
* Creates a {@link Rpc} instance given an {@link RpcApi | RpcApi<TRpcMethods>} and a | |||
* Creates a {@link Rpc} instance given a {@link RpcApi | RpcApi<TRpcMethods>} and a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#yolo grammar fix.
@@ -40,7 +40,7 @@ try { | |||
|
|||
### `RpcSubscriptionsChannel<TOutboundMessage, TInboundMessage>` | |||
|
|||
A channel is a `DataPublisher` that you can subscribe to events of type `RpcSubscriptionChannelEvents<TInboundMessage>`. Additionally, you can use it to send messages of type `TOutboundMessage` back to the remote end by calling the `send(message)` method. | |||
A channel is a `DataPublisher` on which you can subscribe to events of type `RpcSubscriptionChannelEvents<TInboundMessage>`. Additionally, you can use this object to send messages of type `TOutboundMessage` back to the remote end by calling its `send(message)` method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided not to complete the README
here with all the new documentation in this PR. I think after this is all done we just delete all the READMEs and replace them with a link to the live documentation, whether that's on our site or on tsdocs.dev.
BundleMonUnchanged files (127)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
9b1a067
to
1d16cdc
Compare
fe47b6d
to
23d6ef0
Compare
1d16cdc
to
24d33eb
Compare
23d6ef0
to
1d12a42
Compare
24d33eb
to
880a7f3
Compare
1d12a42
to
2c1779c
Compare
2c1779c
to
2ea177a
Compare
880a7f3
to
0f8f024
Compare
2ea177a
to
64d702a
Compare
No description provided.