Skip to content

Conversation

@patchback
Copy link

@patchback patchback bot commented Apr 21, 2025

This is a backport of PR #10043 as merged into main (2a5abab).

SUMMARY

Right now two integration tests skip Python 3 completely in CI.

This either is an oversight that should be fixed, or the tests should be fixed, or the modules should be deprecated.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

hg
supervisorctl

* Remove blanket skips for Python 3 in CI.

* Try to fix hg tests.

* Disable hg tests.

* Drop restriction of supervisor to <4.0.0.

This was introduced in ansible/ansible#54935.

* Make tests work with supervisorctl 4.0.0.

According to https://supervisord.org/changes.html#id12,
"supervisorctl will now set its exit code to a non-zero value when an error condition occurs."
I'm not sure why a stopped service in 'status' constitutes an error condition,
but whatever 🤷...

* Use correct Python executable.

* Skip RHEL/macOS; diff on config write.

* Skip CentOS 7 and OpenSuSE on ansible-core 2.16.

(cherry picked from commit 2a5abab)
@ansibullbot ansibullbot added backport integration tests/integration needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor tests tests labels Apr 21, 2025
@felixfontein felixfontein merged commit 812bef1 into stable-8 Apr 21, 2025
129 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-8/2a5abab7389fa6f601cb8566e6e573656fe99166/pr-10043 branch April 21, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport integration tests/integration needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor tests tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants