Remove blanket skips for Python 3 in CI #10043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
backport-9
backport-10
|
The hg checks might be broken anyway, at least they consistently fail on stable-9 for the (apparently) remaining Python 2 CI run. |
ansibullbot
added
integration
This was introduced in ansible/ansible#54935.
ansibullbot
added
needs_revision
According to https://supervisord.org/changes.html#id12, "supervisorctl will now set its exit code to a non-zero value when an error condition occurs." I'm not sure why a stopped service in 'status' constitutes an error condition, but whatever 🤷...
1 task
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #10046 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 21, 2025
* Remove blanket skips for Python 3 in CI. * Try to fix hg tests. * Disable hg tests. * Drop restriction of supervisor to <4.0.0. This was introduced in ansible/ansible#54935. * Make tests work with supervisorctl 4.0.0. According to https://supervisord.org/changes.html#id12, "supervisorctl will now set its exit code to a non-zero value when an error condition occurs." I'm not sure why a stopped service in 'status' constitutes an error condition, but whatever 🤷... * Use correct Python executable. * Skip RHEL/macOS; diff on config write. * Skip CentOS 7 and OpenSuSE on ansible-core 2.16. (cherry picked from commit 2a5abab)
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #10047 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 21, 2025
* Remove blanket skips for Python 3 in CI. * Try to fix hg tests. * Disable hg tests. * Drop restriction of supervisor to <4.0.0. This was introduced in ansible/ansible#54935. * Make tests work with supervisorctl 4.0.0. According to https://supervisord.org/changes.html#id12, "supervisorctl will now set its exit code to a non-zero value when an error condition occurs." I'm not sure why a stopped service in 'status' constitutes an error condition, but whatever 🤷... * Use correct Python executable. * Skip RHEL/macOS; diff on config write. * Skip CentOS 7 and OpenSuSE on ansible-core 2.16. (cherry picked from commit 2a5abab)
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #10048 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 21, 2025
* Remove blanket skips for Python 3 in CI. * Try to fix hg tests. * Disable hg tests. * Drop restriction of supervisor to <4.0.0. This was introduced in ansible/ansible#54935. * Make tests work with supervisorctl 4.0.0. According to https://supervisord.org/changes.html#id12, "supervisorctl will now set its exit code to a non-zero value when an error condition occurs." I'm not sure why a stopped service in 'status' constitutes an error condition, but whatever 🤷... * Use correct Python executable. * Skip RHEL/macOS; diff on config write. * Skip CentOS 7 and OpenSuSE on ansible-core 2.16. (cherry picked from commit 2a5abab)
felixfontein
added a commit
that referenced
this pull request
Apr 21, 2025
…hon 3 in CI (#10048) Remove blanket skips for Python 3 in CI (#10043) * Remove blanket skips for Python 3 in CI. * Try to fix hg tests. * Disable hg tests. * Drop restriction of supervisor to <4.0.0. This was introduced in ansible/ansible#54935. * Make tests work with supervisorctl 4.0.0. According to https://supervisord.org/changes.html#id12, "supervisorctl will now set its exit code to a non-zero value when an error condition occurs." I'm not sure why a stopped service in 'status' constitutes an error condition, but whatever 🤷... * Use correct Python executable. * Skip RHEL/macOS; diff on config write. * Skip CentOS 7 and OpenSuSE on ansible-core 2.16. (cherry picked from commit 2a5abab) Co-authored-by: Felix Fontein <[email protected]>
felixfontein
added a commit
that referenced
this pull request
Apr 21, 2025
…on 3 in CI (#10046) * Remove blanket skips for Python 3 in CI (#10043) * Remove blanket skips for Python 3 in CI. * Try to fix hg tests. * Disable hg tests. * Drop restriction of supervisor to <4.0.0. This was introduced in ansible/ansible#54935. * Make tests work with supervisorctl 4.0.0. According to https://supervisord.org/changes.html#id12, "supervisorctl will now set its exit code to a non-zero value when an error condition occurs." I'm not sure why a stopped service in 'status' constitutes an error condition, but whatever 🤷... * Use correct Python executable. * Skip RHEL/macOS; diff on config write. * Skip CentOS 7 and OpenSuSE on ansible-core 2.16. (cherry picked from commit 2a5abab) * Skip OpenSuSE 15/Python 2 on ansible-core 2.13. --------- Co-authored-by: Felix Fontein <[email protected]>
felixfontein
added a commit
that referenced
this pull request
Apr 21, 2025
…on 3 in CI (#10047) * Remove blanket skips for Python 3 in CI (#10043) * Remove blanket skips for Python 3 in CI. * Try to fix hg tests. * Disable hg tests. * Drop restriction of supervisor to <4.0.0. This was introduced in ansible/ansible#54935. * Make tests work with supervisorctl 4.0.0. According to https://supervisord.org/changes.html#id12, "supervisorctl will now set its exit code to a non-zero value when an error condition occurs." I'm not sure why a stopped service in 'status' constitutes an error condition, but whatever 🤷... * Use correct Python executable. * Skip RHEL/macOS; diff on config write. * Skip CentOS 7 and OpenSuSE on ansible-core 2.16. (cherry picked from commit 2a5abab) * Skip OpenSuSE 15/Python 2 on ansible-core 2.13. --------- Co-authored-by: Felix Fontein <[email protected]>
shinuza
pushed a commit
to shinuza/community.general
that referenced
this pull request
Jul 22, 2025
* Remove blanket skips for Python 3 in CI. * Try to fix hg tests. * Disable hg tests. * Drop restriction of supervisor to <4.0.0. This was introduced in ansible/ansible#54935. * Make tests work with supervisorctl 4.0.0. According to https://supervisord.org/changes.html#id12, "supervisorctl will now set its exit code to a non-zero value when an error condition occurs." I'm not sure why a stopped service in 'status' constitutes an error condition, but whatever 🤷... * Use correct Python executable. * Skip RHEL/macOS; diff on config write. * Skip CentOS 7 and OpenSuSE on ansible-core 2.16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Right now two integration tests skip Python 3 completely in CI.
This either is an oversight that should be fixed, or the tests should be fixed, or the modules should be deprecated.
ISSUE TYPE
COMPONENT NAME
hg
supervisorctl