Skip to content

Allowing uppercase tags in proxmox & proxmox_kvm #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

Allowing uppercase tags in proxmox & proxmox_kvm #10024

merged 2 commits into from
Apr 21, 2025

Conversation

@s1github
Copy link
Contributor

@s1github s1github commented Apr 20, 2025

  • Fix the 'not a valid tag' error message when the VM or container tag contains uppercase characters
SUMMARY

Fixes #9895

minor_changes:

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox, proxmox_kvm

ADDITIONAL INFORMATION

Regexp pattern updated to allow uppercase characters in VM and container tags, as there is no such limitation in the PVE WebUI.

- name: Now working example creating new VM with tags including uppercase letters
  community.general.proxmox_kvm:
    api_user: root@pam
    api_password: secret
    api_host: helldorado
    name: spynal
    node: sabrewulf
    tags:
      - Debian
      - DEBIAN
      - dEBIAN

Allowing uppercase tags in proxmox & proxmox_kvm
79168a4 
* Fix ansible-collections#9895 : fixes the 'not a valid tag' error message when the VM or container tag contains uppercase characters
@ansibullbot
Copy link
Collaborator

ansibullbot commented Apr 20, 2025

cc @Ajpantuso @Thulium-Drake @UnderGreen @helldorado @joshainglis @karmab @krauthosting
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Apr 20, 2025
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-9 backport-10 Automatically create a backport for the stable-10 branch and removed backport-9 labels Apr 20, 2025
russoz
russoz approved these changes Apr 20, 2025
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

felixfontein
felixfontein reviewed Apr 20, 2025
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@felixfontein felixfontein merged commit ce421db into ansible-collections:main Apr 21, 2025
141 checks passed
@patchback
Copy link

patchback bot commented Apr 21, 2025 •
edited
Loading

Backport to stable-10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-10/ce421dbd7d9ccc67680509af7286a943c46a0c2a/pr-10024

Backported as #10039

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 21, 2025
patchback bot pushed a commit that referenced this pull request Apr 21, 2025
@s1github @felixfontein @patchback
Allowing uppercase tags in proxmox & proxmox_kvm (#10024)
697743a 
* Allowing uppercase tags in proxmox & proxmox_kvm

* Fix #9895 : fixes the 'not a valid tag' error message when the VM or container tag contains uppercase characters

* Add PR URL to changelog fragment.

---------

Co-authored-by: s1githug <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit ce421db)
@patchback patchback bot mentioned this pull request Apr 21, 2025
Merged
@felixfontein
Copy link
Collaborator

felixfontein commented Apr 21, 2025

@s1github thanks for your contribution!
@russoz thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Apr 21, 2025
@patchback @s1github
[PR #10024/ce421dbd backport][stable-10] Allowing uppercase tags in p…
11a847a 
…roxmox & proxmox_kvm (#10039)

Allowing uppercase tags in proxmox & proxmox_kvm (#10024)

* Allowing uppercase tags in proxmox & proxmox_kvm

* Fix #9895 : fixes the 'not a valid tag' error message when the VM or container tag contains uppercase characters

* Add PR URL to changelog fragment.

---------

Co-authored-by: s1githug <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit ce421db)

Co-authored-by: s1github <[email protected]>
shinuza pushed a commit to shinuza/community.general that referenced this pull request Jul 22, 2025
@s1github @felixfontein @shinuza
Allowing uppercase tags in proxmox & proxmox_kvm (ansible-collections…
1c32bf9 
…#10024)

* Allowing uppercase tags in proxmox & proxmox_kvm

* Fix ansible-collections#9895 : fixes the 'not a valid tag' error message when the VM or container tag contains uppercase characters

* Add PR URL to changelog fragment.

---------

Co-authored-by: s1githug <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixfontein felixfontein felixfontein left review comments

@russoz russoz russoz approved these changes

Assignees

No one assigned

Labels

backport-10 Automatically create a backport for the stable-10 branch bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

proxmox and proxmox_kvm modules won't allow uppercase characters in VM/container tags

4 participants

@s1github @ansibullbot @felixfontein @russoz