Allowing uppercase tags in proxmox & proxmox_kvm (#10024)

* Allowing uppercase tags in proxmox & proxmox_kvm

* Fix #9895 : fixes the 'not a valid tag' error message when the VM or container tag contains uppercase characters

* Add PR URL to changelog fragment.

---------

Co-authored-by: s1githug <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>

Author: 3 people

changelogs/fragments/9895-proxmox_tags_with_uppercase_chars.yml

@@ -0,0 +1,2 @@
+minor_changes:
+  - proxmox and proxmox_kvm modules - allow uppercase characters in VM/container tags (https://github.com/ansible-collections/community.general/issues/9895, https://github.com/ansible-collections/community.general/pull/10024).

plugins/modules/proxmox.py

@@ -1696,7 +1696,7 @@ def content_check(self, node, ostemplate, template_store):
 
     def validate_tags(self, tags):
         """Check if the specified tags are valid."""
-        re_tag = re.compile(r"^[a-z0-9_][a-z0-9_\-\+\.]*$")
+        re_tag = re.compile(r"^[a-zA-Z0-9_][a-zA-Z0-9_\-\+\.]*$")
         for tag in tags:
             if not re_tag.match(tag):
                 self.module.fail_json(msg="%s is not a valid tag" % tag)

plugins/modules/proxmox_kvm.py

@@ -1126,7 +1126,7 @@ def create_vm(self, vmid, newid, node, name, memory, cpu, cores, sockets, update
 
         # VM tags are expected to be valid and presented as a comma/semi-colon delimited string
         if 'tags' in kwargs:
-            re_tag = re.compile(r'^[a-z0-9_][a-z0-9_\-\+\.]*$')
+            re_tag = re.compile(r'^[a-zA-Z0-9_][a-zA-Z0-9_\-\+\.]*$')
             for tag in kwargs['tags']:
                 if not re_tag.match(tag):
                     self.module.fail_json(msg='%s is not a valid tag' % tag)

tests/integration/targets/proxmox/tasks/main.yml

@@ -165,6 +165,8 @@
         name: test-instance
         clone: 'yes'
         state: present
+        tags:
+          - TagWithUppercaseChars
         timeout: 500
       register: results_kvm