-
Notifications
You must be signed in to change notification settings - Fork 19
Aleph 446 duplicate nftables rule #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for multiple base chain
897a38c
to
d0b66f7
Compare
d0b66f7
to
8ec2efa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
==========================================
+ Coverage 64.65% 65.27% +0.62%
==========================================
Files 84 85 +1
Lines 7577 7681 +104
Branches 651 664 +13
==========================================
+ Hits 4899 5014 +115
+ Misses 2470 2457 -13
- Partials 208 210 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nesitor
approved these changes
Jun 6, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the creation of duplicate nftables rules
Some of our CRN endup with nftables duplicate rules.
Usually there should be less than an hundred total rule for nftables (measured with sudo nft list ruleset|wc -l ) but some server had thousands of rules, those are duplicate and useless and made the network very slow
Related ClickUp, GitHub or Jira tickets : ALEPH-446