Skip to content

Fix aggregate and redirect issues#811

Closed
nesitor wants to merge 5 commits intomainfrom
andres-fix-solve_firewall_redirect_issues
Closed

Fix aggregate and redirect issues#811
nesitor wants to merge 5 commits intomainfrom
andres-fix-solve_firewall_redirect_issues

Conversation

@nesitor
Copy link
Copy Markdown
Member

@nesitor nesitor commented Jun 5, 2025

Fix: Added missing field on aggregate handling and fixed issue on redirects creation.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

Changes

Fix: Added missing field on aggregate handling and fixed issue on redirects creation.

@nesitor nesitor requested a review from olethanh June 5, 2025 15:47
@nesitor nesitor self-assigned this Jun 5, 2025
@nesitor nesitor force-pushed the andres-fix-solve_firewall_redirect_issues branch from aa85d2b to 75c8f5d Compare June 5, 2025 15:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 64.60%. Comparing base (a787875) to head (2619d6e).

Files with missing lines Patch % Lines
src/aleph/vm/network/firewall.py 0.00% 6 Missing ⚠️
src/aleph/vm/models.py 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   64.65%   64.60%   -0.06%     
==========================================
  Files          84       84              
  Lines        7577     7583       +6     
  Branches      651      652       +1     
==========================================
  Hits         4899     4899              
- Misses       2470     2475       +5     
- Partials      208      209       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh olethanh force-pushed the andres-fix-solve_firewall_redirect_issues branch from b27924d to 2619d6e Compare June 5, 2025 19:40
@nesitor
Copy link
Copy Markdown
Member Author

nesitor commented Jun 6, 2025

Closed in favor of: #812

@nesitor nesitor closed this Jun 6, 2025
@nesitor nesitor deleted the andres-fix-solve_firewall_redirect_issues branch June 6, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants